Skip to content

perf(types): rm conditions to get better performance#3439

Merged
yusukebe merged 1 commit intohonojs:mainfrom
m-shaka:refactor-ExtractKey
Sep 23, 2024
Merged

perf(types): rm conditions to get better performance#3439
yusukebe merged 1 commit intohonojs:mainfrom
m-shaka:refactor-ExtractKey

Conversation

@m-shaka
Copy link
Copy Markdown
Contributor

@m-shaka m-shaka commented Sep 22, 2024

The author should do the following, if applicable

  • Add tests
  • Run tests
  • bun run format:fix && bun run lint:fix to format the code
  • Add TSDoc/JSDoc to document the code

Instantiation ave dropped by more than 10%(3,438,492->2,997,759)
image

@m-shaka m-shaka force-pushed the refactor-ExtractKey branch from b304d3e to 48c50e9 Compare September 22, 2024 11:00
@codecov
Copy link
Copy Markdown

codecov Bot commented Sep 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.77%. Comparing base (66df4e1) to head (48c50e9).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3439   +/-   ##
=======================================
  Coverage   95.77%   95.77%           
=======================================
  Files         155      155           
  Lines        9310     9310           
  Branches     2759     2730   -29     
=======================================
  Hits         8917     8917           
  Misses        393      393           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@m-shaka m-shaka marked this pull request as ready for review September 22, 2024 11:06
@yusukebe yusukebe changed the title refactor(types): rm conditions to get better performance perf(types): rm conditions to get better performance Sep 23, 2024
Copy link
Copy Markdown
Member

@yusukebe yusukebe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@yusukebe
Copy link
Copy Markdown
Member

@m-shaka

Wow. Great! Thanks to perf-measures/type-check. Merging. Thanks.

@yusukebe yusukebe merged commit bb63ee2 into honojs:main Sep 23, 2024
TinsFox pushed a commit to TinsFox/hono that referenced this pull request Oct 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants