Skip to content

chore: use giget v2#85

Closed
ryuapp wants to merge 3 commits intohonojs:mainfrom
ryuapp-contrib:update-giget-v2
Closed

chore: use giget v2#85
ryuapp wants to merge 3 commits intohonojs:mainfrom
ryuapp-contrib:update-giget-v2

Conversation

@ryuapp
Copy link
Copy Markdown
Contributor

@ryuapp ryuapp commented Feb 26, 2025

Fix #51
giget v2 patches internal library and fixes the bug in Bun.

@yusukebe
Copy link
Copy Markdown
Member

Hi @ryuapp

Thank you for the PR. The CI is failing. Can you correct it?

@ryuapp
Copy link
Copy Markdown
Contributor Author

ryuapp commented Feb 27, 2025

Github Actions was not working just in time, so I think that's the cause. I'll check it later.
https://www.githubstatus.com/incidents/2lxm4wb8wy3r

@yusukebe
Copy link
Copy Markdown
Member

Hi @ryuapp

For your information. I tried to test this branch on my machine. But it fails.

CleanShot 2025-02-28 at 14 45 24@2x

@ryuapp
Copy link
Copy Markdown
Contributor Author

ryuapp commented Feb 28, 2025

@yusukebe
Thanks for your investigation. Since v2 has become an esm-only package, that may become a problem.
Once the tests is passed, I'll mention you again.

@ryuapp ryuapp marked this pull request as draft February 28, 2025 06:03
@yusukebe
Copy link
Copy Markdown
Member

@ryuapp

Thank you!

@ryuapp
Copy link
Copy Markdown
Contributor Author

ryuapp commented Apr 1, 2025

I agree with the approach in #91, so I'm closing this PR. Please see #91. Thank you.

@ryuapp ryuapp closed this Apr 1, 2025
@ryuapp ryuapp deleted the update-giget-v2 branch April 1, 2025 00:34
@ryoppippi
Copy link
Copy Markdown
Contributor

ryoppippi commented Apr 1, 2025

@ryuapp Actually I didn't notice this PR when I created #91 .
I know you work so hard on this command. I respect you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bun create hono on Windows can't clone templates without Node.js

3 participants