Skip to content

chore(deps): replace giget with @bluwy/giget-core#91

Merged
yusukebe merged 2 commits intohonojs:mainfrom
ryoppippi:feature/replace-giget
Apr 7, 2025
Merged

chore(deps): replace giget with @bluwy/giget-core#91
yusukebe merged 2 commits intohonojs:mainfrom
ryoppippi:feature/replace-giget

Conversation

@ryoppippi
Copy link
Copy Markdown
Contributor

@ryoppippi ryoppippi commented Apr 1, 2025 •
edited
Loading

Hi @yusukebe !
I love Hono as always! Thank you!

In this PR, we replace giget with @bluwy/giget-core.
@bluwy/giget-core is smaller version of giget and it is used in create-astro cli!

so I gonna test the bundle size, and it is 60% smaller!!! OMG!

~/g/g/h/create-hono main ❱ bun run build
$ tsx ./build.ts
~/g/g/h/create-hono main ❱ ls -hlA bin
Permissions Size User      Date Modified Name
.rw-r--r--@ 1.4M ryoppippi  1 Apr 01:15  bin

~/g/g/h/create-hono main ❱ git sw feature/replace-giget
~/g/g/h/create-hono feature/replace-giget ❱ bun i && bun run build
$ tsx ./build.ts
~/g/g/h/create-hono feature/replace-giget ❱ ls -hlA bin
Permissions Size User      Date Modified Name
.rw-r--r--@ 552k ryoppippi  1 Apr 01:15  bin

@ryoppippi
Copy link
Copy Markdown
Contributor Author

ryoppippi commented Apr 1, 2025 •
edited
Loading

oh wait this cli tool is built with cjs!! so it doesn't work i think.

@bluwy/giget-core is esm only library!

@ryoppippi ryoppippi mentioned this pull request Apr 1, 2025
Closed
@ryoppippi
Copy link
Copy Markdown
Contributor Author

ryoppippi commented Apr 1, 2025

after #92 is merged I open this

@ryoppippi ryoppippi marked this pull request as draft April 1, 2025 00:24
@ryuapp ryuapp mentioned this pull request Apr 1, 2025
Closed
@ryoppippi ryoppippi marked this pull request as ready for review April 6, 2025 11:55
@ryoppippi
Copy link
Copy Markdown
Contributor Author

ryoppippi commented Apr 6, 2025

we have esbuild, so we can use esm-only package in cjs format!
Please review it!

@yusukebe yusukebe changed the title replace giget with @bluwy/giget-core feat: replace giget with @bluwy/giget-core Apr 7, 2025
yusukebe
yusukebe approved these changes Apr 7, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@yusukebe yusukebe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@yusukebe
Copy link
Copy Markdown
Member

yusukebe commented Apr 7, 2025

@ryoppippi

This is super cool! It becomes really small. This PR does not change the actual behavior, but reducing the size is significant. So, after merging this, I'll release a new minor version. Thank you!

@yusukebe yusukebe changed the title feat: replace giget with @bluwy/giget-core chore(deps): replace giget with @bluwy/giget-core Apr 7, 2025
@yusukebe yusukebe merged commit 85b9c0b into honojs:main Apr 7, 2025
3 checks passed
@ryoppippi
Copy link
Copy Markdown
Contributor Author

ryoppippi commented Apr 7, 2025

Thanks! Reducing create command size is really important. It is like reducing bundle size of frontend.
I'm happy to contribute to Hono! Thank you!

@ryoppippi ryoppippi deleted the feature/replace-giget branch April 7, 2025 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yusukebe yusukebe yusukebe approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ryoppippi @yusukebe