Try using old image name of the Supervisor image (#2111)#2113
Merged
agners merged 2 commits intohome-assistant:devfrom Sep 6, 2022
Merged
Try using old image name of the Supervisor image (#2111)#2113agners merged 2 commits intohome-assistant:devfrom
agners merged 2 commits intohome-assistant:devfrom
Conversation
Member
Author
|
Actually I realized that isn't all, as the Container will get recreated. We need to also use it at container creation time. |
Member
Author
|
With that, a boot without Internet right after OS update succeeds: |
Member
Author
|
Discussed with @pvizeli: We could also fix this in Supervisor by tagging the image with the ghcr name and the |
agners
added a commit
to agners/operating-system
that referenced
this pull request
Sep 8, 2022
home-assistant#2113) * Try using old image name of the Supervisor image * Tag the old image with the new name so recreation works
agners
added a commit
that referenced
this pull request
Nov 30, 2023
As noted in #2113, we don't need this logic anymore after a major OS releases. So simply drop the logic to also make the image corruption detection work again.
agners
added a commit
that referenced
this pull request
Nov 30, 2023
* Fix Supervisor image corruption detection When multiple images match the reference, multiple IDs are passed as a single argument to docker image rm, leading to an error: Error response from daemon: page not found Make sure to pass the ids as separate argument to make the delete work in any case. * Cleanup reusing Supervisor from an old/unused reference As noted in #2113, we don't need this logic anymore after a major OS releases. So simply drop the logic to also make the image corruption detection work again. * Make sure image IDs are sorted to make them unique
agners
added a commit
that referenced
this pull request
Dec 4, 2023
* Fix Supervisor image corruption detection When multiple images match the reference, multiple IDs are passed as a single argument to docker image rm, leading to an error: Error response from daemon: page not found Make sure to pass the ids as separate argument to make the delete work in any case. * Cleanup reusing Supervisor from an old/unused reference As noted in #2113, we don't need this logic anymore after a major OS releases. So simply drop the logic to also make the image corruption detection work again. * Make sure image IDs are sorted to make them unique
darkxst
pushed a commit
to darkxst/ha-operating-system
that referenced
this pull request
Dec 9, 2023
* Fix Supervisor image corruption detection When multiple images match the reference, multiple IDs are passed as a single argument to docker image rm, leading to an error: Error response from daemon: page not found Make sure to pass the ids as separate argument to make the delete work in any case. * Cleanup reusing Supervisor from an old/unused reference As noted in home-assistant#2113, we don't need this logic anymore after a major OS releases. So simply drop the logic to also make the image corruption detection work again. * Make sure image IDs are sorted to make them unique
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.