Skip to content

Include more test cases for record_duration#272

Merged
skjerns merged 1 commit intomasterfrom
recorddruation_addon
Jan 23, 2025
Merged

Include more test cases for record_duration#272
skjerns merged 1 commit intomasterfrom
recorddruation_addon

Conversation

@skjerns
Copy link
Copy Markdown
Collaborator

@skjerns skjerns commented Jan 23, 2025

Based on #238 and #242 I assessed the recent changes in #268 and improved the changes

  • added more test cases for different manual record_durations
  • due to the conversion to long long we are limited to record durations between 0.001 and 60, which should be fine for most cases
  • checking for str(float) can lead to output of scientific notation, so force floating point notation with f{x:f}
  • To check for valid writing of record_duration, read the raw header instead of EdfWriter, as a safety check.

fixes #238

@skjerns skjerns merged commit ccd9dc1 into master Jan 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Documentation issue

1 participant