Conversation
Collaborator
Author
|
@cbrnr @cfranklin11 @LucaCerina @raphaelvallat @DimitriPapadopoulos if any of you has time to have a look, that would be great :) |
This was referenced Jan 18, 2025
Contributor
|
Good also for me |
cbrnr
reviewed
Jan 20, 2025
Contributor
cbrnr
left a comment
There was a problem hiding this comment.
Just a few minor suggestions, otherwise LGTM (although I didn't check the record duration calculation since I don't have the time at the moment).
Collaborator
Author
|
Found something strange: Even though the f.setDatarecordDuration(0.123456)
...
AssertionError: read 0.12345 != expected 0.123456In the raw header there is an empty space
this issue might be related #242. I suggest fixing this in a future PR. |
Collaborator
Author
|
Given that the the requested changes were minor, I'll merge this one :) thanks for reviewing! |
This was referenced Jan 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As discussed in #247 , I deprecated
sample_rateand replaced all of its occurences withsample_frequency.Frequency is usually measured in Hz, which is defined per second and is most consistent with other libraries (e.g.
mne).Summary
sample_rate- this is to ensure everyone finds out about the change without googelingrecord_duration- it should find an optimal value if one exists and let users not worry about thesample_rateas it is defined inedflibbut to simply seysample_frequencyand be donerecord_durationif ppl actually need to for obscure reasonsAdditionally, needed to deprecate 3.7 for the test suite as it's not available for ubuntu24
fixes #198
closes #247