-
Notifications
You must be signed in to change notification settings - Fork 5
iPhone X support and additional Safe Area insets support #1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@toohotz Thank your for Gread PR! |
|
No problem 👍🏾, you might want the changes for yourself as well as it fixes the things with the trailing and bottom to superview along with the inequalities and other methods as well. The maintainer of the repo seems like he is going to reach out for some others to help keep things alive but I'll drop a note there referring to this PR as well. |
|
Hey there, are you going to integrate these changes into your fork? |
|
@toohotz |
| constraint = [[self rightAnchor] constraintEqualToAnchor:rightAnchor constant:inset]; | ||
| break; | ||
| case NSLayoutRelationLessThanOrEqual: | ||
| constraint = [[self leftAnchor] constraintGreaterThanOrEqualToAnchor:rightAnchor constant:inset]; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@toohotz Is this mistake of rightAnchor ?
I think it expect:
constraint = [[self rightAnchor] constraintGreaterThanOrEqualToAnchor:rightAnchor constant:inset];If not, Please tell me your intension.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch, copy pasted had caused the issue, will fix it thank you for catching.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. Other code feel good, so I will merge as soon as it's fixed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No problem, done.
|
Thanks! |
|
Hey guys, I found your approach using NSLayoutAnchor is great, some how I found that there is some compatibility problem if targeting iOS 8.0, the NSLayoutAnchor is only available in iOS 9.0, so if I run the app in iOS 8 (pretty old system), it will cause crash. Although PureLayout do claim that fully compatible with iOS 9.0 but at least it won't crash even if it target the iOS 8.0. |
|
@jjksam Agreed, |
Rebasing to PureLayout:master
No description provided.