1) Remove instance number data element if remove() is called so subseque...#27
Closed
assiotis wants to merge 1 commit intohilios:masterfrom
Closed
1) Remove instance number data element if remove() is called so subseque...#27assiotis wants to merge 1 commit intohilios:masterfrom
assiotis wants to merge 1 commit intohilios:masterfrom
Conversation
…quent initializations create a new object 2) If only one instance is on the page then the `if (instanceNumber)` check does not behave as expected. Change to `!= null` instead
Owner
|
Duplicated in #24. As this PR breaks the build and further tech discussion is occurring in the other PR I will close this one. If would like to contribute please use the issue above. Thank you for the collaboration! |
hilios
pushed a commit
that referenced
this pull request
Dec 29, 2013
…removal (thanks to @assiotis)
Owner
|
Hello mate, I've been reviewing the PRs lately and notice that yours have a fix that remove the countdown instance upon removal. I've included this fix to the latest code with proper unit testing and added you to the contributors list. Thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
...nt
initializations create a new object
if (instanceNumber)check does not behave as expected. Change to
!= nullinstead