Add AMD support#15
Conversation
|
haha forgot to add the pull request 2 days ago, just let me know your thoughts regarding this |
|
LGTM, thanks man! |
|
@FagnerMartinsBrack remember I told you about a plugin refactor? Well I managed to get time this week to accomplish this task. The amount of updates where so large that I finished by almost rewriting the plugin, so I called this revision 2.0.0 instead of 1.0.1. I will launch both in the same time, because the ~2.0 does not support jquery 1.6 and ~1.0 does. I totally understand your point about testing the AMD support, I agree that this shouldn't be included has a test case, but, has a test scenario I think is worth it. This means, see if all current test cases are being executed when RequireJS is included. In this refactor I tried to cover as many jQuery versions as I could, for each one I created a scenario for it. I also received an issue about the plugin is not working with bootstrap, so I generated another scenario including bootstrap.js as well. See where I am coming? If you could help me with this issue it would be great, I already created an HTML (the scenario) to run the plugin with RequireJS, but I really dunno how to make everything work together. You can see code at branch BR, |
|
Let me see if I understand: You just want to make the whole test suite run using requireJS instead of creating an specific test for that matter, is that correct? |
|
Actually is not that simple, you need to call |
No description provided.