Skip to content

revert single style sheet serialization due to performance regression#9631

Merged
Vadman97 merged 7 commits intomainfrom
vadim/rrweb-single-style-perf
Nov 20, 2024
Merged

revert single style sheet serialization due to performance regression#9631
Vadman97 merged 7 commits intomainfrom
vadim/rrweb-single-style-perf

Conversation

@Vadman97
Copy link
Member

@Vadman97 Vadman97 commented Nov 15, 2024

Summary

Revert rrweb-io/rrweb#1437 from rrweb to avoid performance regression with single style serialization.

How did you test this change?

https://www.loom.com/share/674060730e1647819b9fbfd0c05972af

Are there any deployment considerations?

changeset

Does this work require review from our design team?

no

@Vadman97 Vadman97 requested review from a team and ccschmitz and removed request for a team November 15, 2024 18:54
@changeset-bot
Copy link

changeset-bot bot commented Nov 15, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 531b8da

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

💥 An error occurred when fetching the changed packages and changesets in this PR 
Some errors occurred when validating the changesets config:
The package or glob expression "rrdom" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.
The package or glob expression "rrdom-nodejs" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.
The package or glob expression "rrweb" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.
The package or glob expression "rrweb-player" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.
The package or glob expression "rrweb-snapshot" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.
The package or glob expression "@rrweb/all" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.
The package or glob expression "@rrweb/types" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.
The package or glob expression "@rrweb/record" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.
The package or glob expression "@rrweb/replay" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.
The package or glob expression "@rrweb/packer" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.
The package or glob expression "@rrweb/rrweb-plugin-canvas-webrtc-record" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.
The package or glob expression "@rrweb/rrweb-plugin-canvas-webrtc-replay" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.
The package or glob expression "@rrweb/rrweb-plugin-console-record" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.
The package or glob expression "@rrweb/rrweb-plugin-console-replay" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.
The package or glob expression "@rrweb/rrweb-plugin-sequential-id-record" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.
The package or glob expression "@rrweb/rrweb-plugin-sequential-id-replay" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.
The package or glob expression "@rrweb/utils" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.
The package or glob expression "@rrweb/web-extension" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.
The package or glob expression "rrvideo" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.

@Vadman97 Vadman97 force-pushed the vadim/rrweb-single-style-perf branch from 1724540 to 53f36f7 Compare November 15, 2024 18:58
@Vadman97 Vadman97 force-pushed the vadim/rrweb-single-style-perf branch from 53f36f7 to 9adea42 Compare November 15, 2024 20:29
github-advanced-security[bot]
github-advanced-security bot found potential problems Nov 15, 2024
View reviewed changes
__generated/rr/rrweb/rr.js
}
if (tagName === "style" && n2.sheet) {
let cssText = stringifyStylesheet(
if (tagName === "style" && n2.sheet && // TODO: Currently we only try to get dynamic stylesheet when it is an empty style element

Check notice

Code scanning / devskim

A "TODO" or similar was left in source code, possibly indicating incomplete functionality

Suspicious comment
@Vadman97
RELEASING: Releasing 4 package(s)
aeb1817 
Releases:
  highlight.run@9.7.1
  @highlight-run/next@7.6.10
  @highlight-run/react@8.0.1
  @highlight-run/remix@2.0.73
@Vadman97
TMP force deploy
87227ff
@Vadman97 Vadman97 force-pushed the vadim/rrweb-single-style-perf branch from 5bce838 to 87227ff Compare November 15, 2024 21:36
@Vadman97
Revert "TMP force deploy"
531b8da 
This reverts commit 87227ff.
@Vadman97 Vadman97 enabled auto-merge (squash) November 15, 2024 23:42
@Vadman97 Vadman97 merged commit 6c734cf into main Nov 20, 2024
@Vadman97 Vadman97 deleted the vadim/rrweb-single-style-perf branch November 20, 2024 17:40
giraffekey pushed a commit to giraffekey/highlight that referenced this pull request Nov 21, 2024
@Vadman97 @giraffekey
revert single style sheet serialization due to performance regression (…
af7fea6 
…highlight#9631)

## Summary

Revert rrweb-io/rrweb#1437 from rrweb to avoid
performance regression with single style serialization.

## How did you test this change?

https://www.loom.com/share/674060730e1647819b9fbfd0c05972af

## Are there any deployment considerations?

changeset

## Does this work require review from our design team?

no
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ccschmitz ccschmitz ccschmitz approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Vadman97 @ccschmitz