Skip to content

feat: add recent history in search#9453

Merged
Vadman97 merged 20 commits intohighlight:mainfrom
rajesh-jonnalagadda:feat-8785-recent-history
Nov 6, 2024
Merged

feat: add recent history in search#9453
Vadman97 merged 20 commits intohighlight:mainfrom
rajesh-jonnalagadda:feat-8785-recent-history

Conversation

@rajesh-jonnalagadda
Copy link
Copy Markdown
Contributor

@rajesh-jonnalagadda rajesh-jonnalagadda commented Oct 12, 2024

Summary

closes #8785
/claim #8785

How did you test this change?

Are there any deployment considerations?

Does this work require review from our design team?

@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Oct 12, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 8232ea8

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

💥 An error occurred when fetching the changed packages and changesets in this PR 
Some errors occurred when validating the changesets config:
The package or glob expression "rrdom" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.
The package or glob expression "rrdom-nodejs" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.
The package or glob expression "rrweb" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.
The package or glob expression "rrweb-player" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.
The package or glob expression "rrweb-snapshot" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.
The package or glob expression "@rrweb/all" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.
The package or glob expression "@rrweb/types" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.
The package or glob expression "@rrweb/record" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.
The package or glob expression "@rrweb/replay" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.
The package or glob expression "@rrweb/packer" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.
The package or glob expression "@rrweb/rrweb-plugin-canvas-webrtc-record" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.
The package or glob expression "@rrweb/rrweb-plugin-canvas-webrtc-replay" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.
The package or glob expression "@rrweb/rrweb-plugin-console-record" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.
The package or glob expression "@rrweb/rrweb-plugin-console-replay" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.
The package or glob expression "@rrweb/rrweb-plugin-sequential-id-record" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.
The package or glob expression "@rrweb/rrweb-plugin-sequential-id-replay" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.
The package or glob expression "@rrweb/utils" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.
The package or glob expression "@rrweb/web-extension" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.
The package or glob expression "rrvideo" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.

@algora-pbc algora-pbc bot mentioned this pull request Oct 12, 2024
Closed
@rajesh-jonnalagadda
Copy link
Copy Markdown
Contributor Author

rajesh-jonnalagadda commented Oct 13, 2024

@Vadman97 please review

@Vadman97 Vadman97 requested review from a team and Vadman97 October 14, 2024 03:19
Vadman97
Vadman97 reviewed Oct 15, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@Vadman97 Vadman97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for taking this on, @rajeshj11 ! have some quick initial feedback: https://www.loom.com/share/52f227c9c6ef45049908bcbca3e26681

@julian-highlight , would you be able to review the styles? here's the reflame preview

@rajesh-jonnalagadda
Copy link
Copy Markdown
Contributor Author

rajesh-jonnalagadda commented Oct 15, 2024

thanks for taking this on, @rajeshj11 ! have some quick initial feedback: https://www.loom.com/share/52f227c9c6ef45049908bcbca3e26681

@julian-highlight , would you be able to review the styles? here's the reflame preview

thanks for your feedback will work on it and update you

@rajesh-jonnalagadda
Copy link
Copy Markdown
Contributor Author

rajesh-jonnalagadda commented Oct 15, 2024

@Vadman97 Worked on the feedback changes. please review

@rajesh-jonnalagadda
Copy link
Copy Markdown
Contributor Author

rajesh-jonnalagadda commented Oct 21, 2024

@Vadman97 Can you please review

@rajesh-jonnalagadda rajesh-jonnalagadda marked this pull request as draft October 22, 2024 08:40
@rajesh-jonnalagadda rajesh-jonnalagadda marked this pull request as ready for review October 22, 2024 08:40
@rajesh-jonnalagadda
Copy link
Copy Markdown
Contributor Author

rajesh-jonnalagadda commented Oct 23, 2024

@Vadman97 Can you please review

@Vadman97 ^^

@rajesh-jonnalagadda
Copy link
Copy Markdown
Contributor Author

rajesh-jonnalagadda commented Oct 24, 2024

@Vadman97 Following up on the review

@rajesh-jonnalagadda
Copy link
Copy Markdown
Contributor Author

rajesh-jonnalagadda commented Oct 25, 2024 •
edited
Loading

@Vadman97 Sorry for following up too many times. please let me know if it needs any changes.

@rajesh-jonnalagadda
Copy link
Copy Markdown
Contributor Author

rajesh-jonnalagadda commented Nov 2, 2024

@Vadman97 Updated please check

@rajesh-jonnalagadda
Copy link
Copy Markdown
Contributor Author

rajesh-jonnalagadda commented Nov 4, 2024

@Vadman97 Can you please review the latest changes

Vadman97
Vadman97 approved these changes Nov 6, 2024
View reviewed changes
Vadman97
Vadman97 approved these changes Nov 6, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@Vadman97 Vadman97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just one more UX improvement request: https://www.loom.com/share/f3d046d53f764dfabf6080f8e4f6cf78

frontend/src/components/Search/SearchForm/SearchForm.tsx Outdated
Comment on lines +660 to +661
comboboxStore.setActiveId(null)
comboboxStore.setState('moves', 0)
Copy link
Copy Markdown
Member

@Vadman97 Vadman97 Nov 6, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry for all the back-and-forth, this should be the last feedback point
https://www.loom.com/share/f3d046d53f764dfabf6080f8e4f6cf78

@rajesh-jonnalagadda rajesh-jonnalagadda marked this pull request as draft November 6, 2024 07:28
@rajesh-jonnalagadda rajesh-jonnalagadda marked this pull request as ready for review November 6, 2024 07:53
@rajesh-jonnalagadda
Copy link
Copy Markdown
Contributor Author

rajesh-jonnalagadda commented Nov 6, 2024

@Vadman97 Updated the pr. please check

Vadman97
Vadman97 approved these changes Nov 6, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@Vadman97 Vadman97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

new behavior looks good, just a new rendering bug

@Vadman97
Copy link
Copy Markdown
Member

Vadman97 commented Nov 6, 2024

looks great! merging shortly

@Vadman97 Vadman97 merged commit 05d1c0f into highlight:main Nov 6, 2024
@rajesh-jonnalagadda rajesh-jonnalagadda deleted the feat-8785-recent-history branch November 6, 2024 18:35
giraffekey pushed a commit to giraffekey/highlight that referenced this pull request Nov 21, 2024
@rajesh-jonnalagadda @giraffekey
feat: add recent history in search (highlight#9453)
2678ab2 
## Summary

<!--
Ideally, there is an attached GitHub issue that will describe the "why".

If relevant, use this section to call out any additional information
you'd like to _highlight_ to the reviewer.
-->
closes highlight#8785 
/claim highlight#8785 
## How did you test this change?

<!--
Frontend - Leave a screencast or a screenshot to visually describe the
changes.
-->

## Are there any deployment considerations?

<!--
 Backend - Do we need to consider migrations or backfilling data?
-->

## Does this work require review from our design team?

<!--
 Request review from julian-highlight / our design team 
-->

---------

Co-authored-by: Rajesh Jonnalagadda <38752904+rajeshj11@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Vadman97 Vadman97 Awaiting requested review from Vadman97

Assignees

No one assigned

Labels

🙋 Bounty claim

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

add a history of recent searches

2 participants

@rajesh-jonnalagadda @Vadman97