Skip to content

[CI] Update docker image for Publish workflow#483

Merged
vadiklyutiy merged 1 commit intomainfrom
vadim/update-docker-image
Dec 21, 2024
Merged

[CI] Update docker image for Publish workflow#483
vadiklyutiy merged 1 commit intomainfrom
vadim/update-docker-image

Conversation

@vadiklyutiy
Copy link
Copy Markdown
Collaborator

Update docker image for Publish workflow to corresponds Tests workflow

@vadiklyutiy vadiklyutiy self-assigned this Dec 21, 2024
@vadiklyutiy vadiklyutiy merged commit 05f91e8 into main Dec 21, 2024
@vadiklyutiy vadiklyutiy deleted the vadim/update-docker-image branch December 24, 2024 16:55
vadiklyutiy added a commit that referenced this pull request Dec 26, 2024
Fix #478 

1. Add bound check for task mapping worker. It helps to support the correctness of task mapping.
2. Remove unnecessary `%` for the first dimension in calculation of index. It is unnecessary after 1.
3. Add additional optimization: if the bound check condition is true then avoid constructing the check.

Testing manually. Look into cases when a bound check was not optimized
directly on the pass. All of them are when we don't use `ThreadIdx`
directly in the worker. Nevertheless in cases that I looked into bound
check was deleted by the next passes.
AndreSlavescu pushed a commit to AndreSlavescu/hidet that referenced this pull request May 31, 2025
Fix hidet-org#478 

1. Add bound check for task mapping worker. It helps to support the correctness of task mapping.
2. Remove unnecessary `%` for the first dimension in calculation of index. It is unnecessary after 1.
3. Add additional optimization: if the bound check condition is true then avoid constructing the check.

Testing manually. Look into cases when a bound check was not optimized
directly on the pass. All of them are when we don't use `ThreadIdx`
directly in the worker. Nevertheless in cases that I looked into bound
check was deleted by the next passes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant