[IR] Support integer subbyte#403
Merged
xiaocenxiaocen merged 4 commits intohidet-org:mainfrom Jan 26, 2024
Merged
Conversation
Contributor
xiaocenxiaocen
commented
Jan 2, 2024
- support sub byte integers in Hidet
Member
|
Hi @xiaocenxiaocen, let me know when the PR is ready to be reviewed, thanks! |
Contributor
Author
Sure. I will work on this in this week and the next week. |
a2b7795 to
803b1c2
Compare
Contributor
Author
|
Hi, @yaoyaoding. This PR is ready for review. Please take a look at it. Thanks. |
Contributor
Author
|
hidet-ci launch |
yaoyaoding
reviewed
Jan 20, 2024
Member
yaoyaoding
left a comment
There was a problem hiding this comment.
Thanks @xiaocenxiaocen for the support of sub-integer type!
It looks good to me overall. And I left some minor suggestions to make some part more consistent with the existing implementation (like the data type).
Feel free to merge this PR by yourself after you resolve those comments.
Contributor
Author
|
$hidet-ci launch |
1 similar comment
Collaborator
|
$hidet-ci launch |
25e9a56 to
87cc2b7
Compare
Contributor
Author
|
$hidet-ci launch |
87cc2b7 to
7121c88
Compare
Contributor
Author
|
$hidet-ci launch |
vadiklyutiy
pushed a commit
that referenced
this pull request
Dec 19, 2024
1. Added `torch.Tensor.as_strided` and `torch.flip` 2. Added support for `rounding_mode == 'trunc'` in torch.divide 3. Registered `torch.new_ones` Longformer model compilation fails with: ``` RuntimeError: cudaDeviceSynchronize failed with error: cudaErrorMisalignedAddress ``` aftering running `fused_matmul_f16_pk_cute_rearrange_add` kernel. Also Nvidia Nsight Compute shows that matmul kernel fails to launch. This PR contains all changes needed to reproduce this issue. To reproduce: 1. check out to `zhumakhan/longformer` branch and 4. python3 tests/benchmarks/bench_transformer.py longformer --------- Co-authored-by: Zhumakhan <nazirzhumakhan@gmail,.com>
vadiklyutiy
pushed a commit
that referenced
this pull request
Dec 20, 2024
1. Added `torch.Tensor.as_strided` and `torch.flip` 2. Added support for `rounding_mode == 'trunc'` in torch.divide 3. Registered `torch.new_ones` Longformer model compilation fails with: ``` RuntimeError: cudaDeviceSynchronize failed with error: cudaErrorMisalignedAddress ``` aftering running `fused_matmul_f16_pk_cute_rearrange_add` kernel. Also Nvidia Nsight Compute shows that matmul kernel fails to launch. This PR contains all changes needed to reproduce this issue. To reproduce: 1. check out to `zhumakhan/longformer` branch and 4. python3 tests/benchmarks/bench_transformer.py longformer --------- Co-authored-by: Zhumakhan <nazirzhumakhan@gmail,.com>
vadiklyutiy
pushed a commit
that referenced
this pull request
Dec 26, 2024
1. Added `torch.Tensor.as_strided` and `torch.flip` 2. Added support for `rounding_mode == 'trunc'` in torch.divide 3. Registered `torch.new_ones` Longformer model compilation fails with: ``` RuntimeError: cudaDeviceSynchronize failed with error: cudaErrorMisalignedAddress ``` aftering running `fused_matmul_f16_pk_cute_rearrange_add` kernel. Also Nvidia Nsight Compute shows that matmul kernel fails to launch. This PR contains all changes needed to reproduce this issue. To reproduce: 1. check out to `zhumakhan/longformer` branch and 4. python3 tests/benchmarks/bench_transformer.py longformer --------- Co-authored-by: Zhumakhan <nazirzhumakhan@gmail,.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.