[Option] Add option to set class Var id attribute to 0 by default#393
Merged
yaoyaoding merged 4 commits intohidet-org:mainfrom Dec 15, 2023
Merged
[Option] Add option to set class Var id attribute to 0 by default#393yaoyaoding merged 4 commits intohidet-org:mainfrom
yaoyaoding merged 4 commits intohidet-org:mainfrom
Conversation
yaoyaoding
reviewed
Dec 15, 2023
Member
yaoyaoding
left a comment
There was a problem hiding this comment.
Thanks @destefy!
Left two minor suggestions.
Member
|
Thanks @destefy! |
vadiklyutiy
pushed a commit
that referenced
this pull request
Dec 19, 2024
…rm` during operator fusion pass (#437) Closes #393 I spent some time looking into the issue without much progress, but I first found that the error message in the linked issue disappeared after commenting out either the `resolve_variant_pass()` or `fuse_operator_pass()` [here](https://github.com/CentML/hidet/blob/bfbb4db6d7792ed3de3be4e9702e597b8fbbe373/python/hidet/graph/transforms/__init__.py#L55-L61). Then, I found that simply adding the `EmbeddingBagOp` to the `NOT_FUSIBLE` set resolves the error. It is a workaround for now, but I am unaware of better solutions.
vadiklyutiy
pushed a commit
that referenced
this pull request
Dec 20, 2024
…rm` during operator fusion pass (#437) Closes #393 I spent some time looking into the issue without much progress, but I first found that the error message in the linked issue disappeared after commenting out either the `resolve_variant_pass()` or `fuse_operator_pass()` [here](https://github.com/CentML/hidet/blob/bfbb4db6d7792ed3de3be4e9702e597b8fbbe373/python/hidet/graph/transforms/__init__.py#L55-L61). Then, I found that simply adding the `EmbeddingBagOp` to the `NOT_FUSIBLE` set resolves the error. It is a workaround for now, but I am unaware of better solutions.
vadiklyutiy
pushed a commit
that referenced
this pull request
Dec 26, 2024
…rm` during operator fusion pass (#437) Closes #393 I spent some time looking into the issue without much progress, but I first found that the error message in the linked issue disappeared after commenting out either the `resolve_variant_pass()` or `fuse_operator_pass()` [here](https://github.com/CentML/hidet/blob/bfbb4db6d7792ed3de3be4e9702e597b8fbbe373/python/hidet/graph/transforms/__init__.py#L55-L61). Then, I found that simply adding the `EmbeddingBagOp` to the `NOT_FUSIBLE` set resolves the error. It is a workaround for now, but I am unaware of better solutions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
By default Var instances will have an id of 0.
This is to ensure that each entire FlowGraph is entirely deterministic given the same interpreter+input.