[Fix][Graph] Write compiled graph to tempfile first#392
Merged
yaoyaoding merged 2 commits intohidet-org:mainfrom Dec 12, 2023
Merged
[Fix][Graph] Write compiled graph to tempfile first#392yaoyaoding merged 2 commits intohidet-org:mainfrom
yaoyaoding merged 2 commits intohidet-org:mainfrom
Conversation
Member
|
Thanks @destefy ! It looks good to me. |
vadiklyutiy
added a commit
that referenced
this pull request
Dec 19, 2024
- sync `requirement.txt` with requirement in `setup.py` - add extras_require - requirements is torch >= 2.3.0
vadiklyutiy
added a commit
that referenced
this pull request
Dec 20, 2024
- sync `requirement.txt` with requirement in `setup.py` - add extras_require - requirements is torch >= 2.3.0
vadiklyutiy
added a commit
that referenced
this pull request
Dec 24, 2024
- sync `requirement.txt` with requirement in `setup.py` - add extras_require - requirements is torch >= 2.3.0
vadiklyutiy
added a commit
that referenced
this pull request
Dec 26, 2024
- sync `requirement.txt` with requirement in `setup.py` - add extras_require - requirements is torch >= 2.3.0
vadiklyutiy
added a commit
that referenced
this pull request
Dec 26, 2024
- sync `requirement.txt` with requirement in `setup.py` - add extras_require - requirements is torch >= 2.3.0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a process is running save_compiled_graph(path) and writing the CompiledGraph zipfile to the disk, another process may think that the CompiledGraph file can be read since os.path.isfile(path) evaluates to true.
This change writes the file to a temporary file first to avoid this race condition.