Merged
Conversation
Contributor
Author
|
This is quite strange, it seems that while the tests I added works on my local machine, it does not work on the CI server. I am investigating if the transformer versions are the same or not. |
Member
|
Have added a CI step to print out the version of installed python packages at #334 . |
Contributor
Author
|
Right, it seems that the transformer version is 4.29.2, when the latest one is 4.31.0. |
Member
|
I see. The github ci will cache the python package (so that we do not need to reinstall the large packages like pytorch for every run), and this also makes some packages not up to date. Just cleared the python cache manually on the ci server. |
Contributor
Author
|
It appears that updating transformers broke torch dynamo for bert, specifically for dynamic=True. This has nothing to do with our backend, though. |
Member
|
I see, could you skip the corresponding tests in this PR? Let's wait for the fix from pytorch people. |
added 2 commits
July 30, 2023 10:48
soodoshll
pushed a commit
to soodoshll/hidet
that referenced
this pull request
Jul 31, 2023
Fix llama2 and add test for num_heads != num_key_value_heads. --------- Co-authored-by: Allan Lin <allan.lin@centml.ai>
soodoshll
added a commit
to soodoshll/hidet
that referenced
this pull request
Aug 4, 2023
author su <soodoshll@gmail.com> 1690484279 -0400 committer Qidong Su <soodoshll@gmail.com> 1691188805 +0000 parent a73fc3e author su <soodoshll@gmail.com> 1690484279 -0400 committer Qidong Su <soodoshll@gmail.com> 1691184810 +0000 shard spec data structure [CI] List package versions in ci (hidet-org#334) update update update update update update update [Models] Llama2 fix (hidet-org#333) Fix llama2 and add test for num_heads != num_key_value_heads. --------- Co-authored-by: Allan Lin <allan.lin@centml.ai> update update update update upate update update update update fix update update update update' remove llama update dependency update update update update update update add llama update update format refactor update update shard spec data structure update update update update update update update format refactor fix update fix fix
soodoshll
added a commit
to soodoshll/hidet
that referenced
this pull request
Aug 15, 2023
author su <soodoshll@gmail.com> 1690484279 -0400 committer Qidong Su <soodoshll@gmail.com> 1691188805 +0000 parent a73fc3e author su <soodoshll@gmail.com> 1690484279 -0400 committer Qidong Su <soodoshll@gmail.com> 1691184810 +0000 shard spec data structure [CI] List package versions in ci (hidet-org#334) update update update update update update update [Models] Llama2 fix (hidet-org#333) Fix llama2 and add test for num_heads != num_key_value_heads. --------- Co-authored-by: Allan Lin <allan.lin@centml.ai> update update update update upate update update update update fix update update update update' remove llama update dependency update update update update update update add llama update update format refactor update update shard spec data structure update update update update update update update format refactor fix update fix fix
vadiklyutiy
pushed a commit
that referenced
this pull request
Jul 22, 2024
vadiklyutiy
pushed a commit
that referenced
this pull request
Jul 23, 2024
vadiklyutiy
pushed a commit
that referenced
this pull request
Dec 26, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix llama2 and add test for num_heads != num_key_value_heads.