[Task] More descriptive kernel names for nsys/ncu#315
Merged
Aalanli merged 1 commit intohidet-org:mainfrom Jul 16, 2023
Merged
Conversation
yaoyaoding
approved these changes
Jul 13, 2023
Member
yaoyaoding
left a comment
There was a problem hiding this comment.
Thanks @Aalanli, this would be helpful when we use nsight system and compute to profile the kernels.
Comment on lines
+29
to
+34
| if self.task is not None: | ||
| name = f'{self.task.name}_compute_{node.name}' | ||
| else: | ||
| name = f'compute_{node.name}' | ||
|
|
||
| with FunctionBuilder(name=name, kind='cpu_kernel') as fb: |
Member
There was a problem hiding this comment.
When the auto scheduler is scheduling a task, the self.task will be the task that is scheduling, thus we do not need to add the if here.
vadiklyutiy
pushed a commit
that referenced
this pull request
Jul 22, 2024
Closes #215 @wangshangsam @yaoyaoding Is this what you expect in #215? Could you please kindly review this PR? Thanks. --------- Co-authored-by: xiaocenxiaocen <xiao.zhang@centml.ai> Co-authored-by: Shang Wang <samshang.wang@mail.utoronto.ca>
vadiklyutiy
pushed a commit
that referenced
this pull request
Jul 23, 2024
Closes #215 @wangshangsam @yaoyaoding Is this what you expect in #215? Could you please kindly review this PR? Thanks. --------- Co-authored-by: xiaocenxiaocen <xiao.zhang@centml.ai> Co-authored-by: Shang Wang <samshang.wang@mail.utoronto.ca>
vadiklyutiy
pushed a commit
that referenced
this pull request
Dec 26, 2024
Closes #215 @wangshangsam @yaoyaoding Is this what you expect in #215? Could you please kindly review this PR? Thanks. --------- Co-authored-by: xiaocenxiaocen <xiao.zhang@centml.ai> Co-authored-by: Shang Wang <samshang.wang@mail.utoronto.ca>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.