[External Tasks] Move task build into method call for external kernel support#282
Merged
yaoyaoding merged 2 commits intohidet-org:mainfrom Jun 19, 2023
Merged
Conversation
Member
|
Thanks @xinli-git ! |
vadiklyutiy
pushed a commit
that referenced
this pull request
Jul 22, 2024
Closes #282 In the interest of time, only supported enough functionality to resolve the `NotImplementedError` in the issue. Also registered the `torch.Tensor.cumsum` method which was encountered in the same model immediately after extending `einsum` Additionally, added a default value `False` to the `inplace` parameter in the function `relu` defined in `register_functions.py` to match the behaviour in PyTorch
vadiklyutiy
pushed a commit
that referenced
this pull request
Jul 23, 2024
Closes #282 In the interest of time, only supported enough functionality to resolve the `NotImplementedError` in the issue. Also registered the `torch.Tensor.cumsum` method which was encountered in the same model immediately after extending `einsum` Additionally, added a default value `False` to the `inplace` parameter in the function `relu` defined in `register_functions.py` to match the behaviour in PyTorch
vadiklyutiy
pushed a commit
that referenced
this pull request
Dec 26, 2024
Closes #282 In the interest of time, only supported enough functionality to resolve the `NotImplementedError` in the issue. Also registered the `torch.Tensor.cumsum` method which was encountered in the same model immediately after extending `einsum` Additionally, added a default value `False` to the `inplace` parameter in the function `relu` defined in `register_functions.py` to match the behaviour in PyTorch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is to support adding tasks from outside of the hidet library that uses external build logic.
User can directly overwrite the
buildfunction to insert custom logic for introducing operators to hidet graph