[Refactor] Remove schedules submodule under hidet.graph.ops#269
Merged
yaoyaoding merged 3 commits intohidet-org:mainfrom Jun 3, 2023
Merged
[Refactor] Remove schedules submodule under hidet.graph.ops#269yaoyaoding merged 3 commits intohidet-org:mainfrom
schedules submodule under hidet.graph.ops#269yaoyaoding merged 3 commits intohidet-org:mainfrom
Conversation
vadiklyutiy
added a commit
that referenced
this pull request
Jul 22, 2024
In this review, I redo the pick-up of the best candidate. Now statistical t-test is used to estimate what schedule is better. Moved this code to python/hidet/utils/benchmark/bench.py` together with another similar code. **Performance improvement for bs=1, A10G** `python tests/benchmarks/bench_vision.py resnet50 --params 1x3x224x224 --dtype float16` _**Before**_ 0.7848 0.7803 0.7808 0.7839 0.7821 0.7887 0.7785 0.7843 0.7857 0.7939 median = 0.7841 stddev = 0.45% _**After**_ 0.7717 0.7708 0.7679 0.7662 0.7717 0.7715 0.7698 0.7692 0.7706 0.7720 median = 0.7707 (**improvement 1.7%**) stddev = 0.19% (**improvement 2.37x**) **Compilation time improvement** g5.x16large instance. 64 threads/32 cores `time python tests/benchmarks/bench_op.py batch_matmul --params 1x4096x4096,1x4096x4096 --dtype float16` **_Before_** real 5m9s _**After**_ real 2m27s
vadiklyutiy
added a commit
that referenced
this pull request
Jul 23, 2024
In this review, I redo the pick-up of the best candidate. Now statistical t-test is used to estimate what schedule is better. Moved this code to python/hidet/utils/benchmark/bench.py` together with another similar code. **Performance improvement for bs=1, A10G** `python tests/benchmarks/bench_vision.py resnet50 --params 1x3x224x224 --dtype float16` _**Before**_ 0.7848 0.7803 0.7808 0.7839 0.7821 0.7887 0.7785 0.7843 0.7857 0.7939 median = 0.7841 stddev = 0.45% _**After**_ 0.7717 0.7708 0.7679 0.7662 0.7717 0.7715 0.7698 0.7692 0.7706 0.7720 median = 0.7707 (**improvement 1.7%**) stddev = 0.19% (**improvement 2.37x**) **Compilation time improvement** g5.x16large instance. 64 threads/32 cores `time python tests/benchmarks/bench_op.py batch_matmul --params 1x4096x4096,1x4096x4096 --dtype float16` **_Before_** real 5m9s _**After**_ real 2m27s
vadiklyutiy
added a commit
that referenced
this pull request
Dec 26, 2024
In this review, I redo the pick-up of the best candidate. Now statistical t-test is used to estimate what schedule is better. Moved this code to python/hidet/utils/benchmark/bench.py` together with another similar code. **Performance improvement for bs=1, A10G** `python tests/benchmarks/bench_vision.py resnet50 --params 1x3x224x224 --dtype float16` _**Before**_ 0.7848 0.7803 0.7808 0.7839 0.7821 0.7887 0.7785 0.7843 0.7857 0.7939 median = 0.7841 stddev = 0.45% _**After**_ 0.7717 0.7708 0.7679 0.7662 0.7717 0.7715 0.7698 0.7692 0.7706 0.7720 median = 0.7707 (**improvement 1.7%**) stddev = 0.19% (**improvement 2.37x**) **Compilation time improvement** g5.x16large instance. 64 threads/32 cores `time python tests/benchmarks/bench_op.py batch_matmul --params 1x4096x4096,1x4096x4096 --dtype float16` **_Before_** real 5m9s _**After**_ real 2m27s
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We have rewritten all schedules templates in Hidet Script, thus, we remove the
schedulessubmodule previously used to put the IR Builder based schedule templates.