[Dynamic Shape] Adding dynamic shape support for reduce#268
Merged
yaoyaoding merged 9 commits intohidet-org:mainfrom Jun 5, 2023
Merged
[Dynamic Shape] Adding dynamic shape support for reduce#268yaoyaoding merged 9 commits intohidet-org:mainfrom
yaoyaoding merged 9 commits intohidet-org:mainfrom
Conversation
yaoyaoding
reviewed
Jun 3, 2023
Member
yaoyaoding
left a comment
There was a problem hiding this comment.
Thanks @Aalanli!
Overall LGTM, left a few minor comments.
Co-authored-by: Yaoyao Ding <dingyaoyao.cs@gmail.com>
vadiklyutiy
added a commit
that referenced
this pull request
Jul 22, 2024
adaptation for matmul_f16 with fp32 accumulation. @yaoyaoding please assign reviewers. Thanks. --------- Co-authored-by: xiaocenxiaocen <xiao.zhang@centml.ai> Co-authored-by: vadiklyutiy <156319763+vadiklyutiy@users.noreply.github.com>
vadiklyutiy
added a commit
that referenced
this pull request
Jul 23, 2024
adaptation for matmul_f16 with fp32 accumulation. @yaoyaoding please assign reviewers. Thanks. --------- Co-authored-by: xiaocenxiaocen <xiao.zhang@centml.ai> Co-authored-by: vadiklyutiy <156319763+vadiklyutiy@users.noreply.github.com>
vadiklyutiy
added a commit
that referenced
this pull request
Dec 26, 2024
adaptation for matmul_f16 with fp32 accumulation. @yaoyaoding please assign reviewers. Thanks. --------- Co-authored-by: xiaocenxiaocen <xiao.zhang@centml.ai> Co-authored-by: vadiklyutiy <156319763+vadiklyutiy@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dynamic shape support for reduce is required by llama.
However, this introduces Expr into launch_bounds, so I add a check for that case.
Future work: