[Fixbug] Add _stacklevel to pytorch softmax mapping#178
Merged
yaoyaoding merged 1 commit intohidet-org:mainfrom Apr 17, 2023
Merged
[Fixbug] Add _stacklevel to pytorch softmax mapping#178yaoyaoding merged 1 commit intohidet-org:mainfrom
_stacklevel to pytorch softmax mapping#178yaoyaoding merged 1 commit intohidet-org:mainfrom
Conversation
vadiklyutiy
added a commit
that referenced
this pull request
Jul 22, 2024
I noticed that we spend sufficient time on creation process in `parallel_imap`. Add `chunksize` arg to `pool.imap` to decrease the overhead. **Results.** `time python bench_op.py matmul_f16 --params 1x4096x4096,1x4096x4096 --dtype float16` `time python bench_op.py batch_matmul --params 1x4096x4096,1x4096x4096 --dtype float16` | Test | Before(s) | After(s) | Improvement | |--------|--------|--------|--------| | matmul_f16 | 42.768 | 42.138 | 1.5% | | batch_matmul | 34m29.1s | 34m10.1s | 0.9% |
vadiklyutiy
added a commit
that referenced
this pull request
Jul 23, 2024
I noticed that we spend sufficient time on creation process in `parallel_imap`. Add `chunksize` arg to `pool.imap` to decrease the overhead. **Results.** `time python bench_op.py matmul_f16 --params 1x4096x4096,1x4096x4096 --dtype float16` `time python bench_op.py batch_matmul --params 1x4096x4096,1x4096x4096 --dtype float16` | Test | Before(s) | After(s) | Improvement | |--------|--------|--------|--------| | matmul_f16 | 42.768 | 42.138 | 1.5% | | batch_matmul | 34m29.1s | 34m10.1s | 0.9% |
vadiklyutiy
added a commit
that referenced
this pull request
Dec 26, 2024
I noticed that we spend sufficient time on creation process in `parallel_imap`. Add `chunksize` arg to `pool.imap` to decrease the overhead. **Results.** `time python bench_op.py matmul_f16 --params 1x4096x4096,1x4096x4096 --dtype float16` `time python bench_op.py batch_matmul --params 1x4096x4096,1x4096x4096 --dtype float16` | Test | Before(s) | After(s) | Improvement | |--------|--------|--------|--------| | matmul_f16 | 42.768 | 42.138 | 1.5% | | batch_matmul | 34m29.1s | 34m10.1s | 0.9% |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #177.