[Dynamo] Added Operator Support#131
Merged
yaoyaoding merged 14 commits intohidet-org:mainfrom Mar 16, 2023
Merged
Conversation
yaoyaoding
requested changes
Mar 7, 2023
Member
yaoyaoding
left a comment
There was a problem hiding this comment.
Overall LGTM, just a minor comment.
yaoyaoding
approved these changes
Mar 16, 2023
Member
yaoyaoding
left a comment
There was a problem hiding this comment.
Looks good to me. A minor issue is to drop the change for ir/primitives/math.py
Member
|
Thanks @AndreSlavescu. |
KTong821
pushed a commit
to KTong821/hidet
that referenced
this pull request
Apr 24, 2024
The previous implementation is incorrect when dealing with a pair of
dimensions that are both symbolic. Minimal example:
import hidet
if __name__ == "__main__":
x = hidet.symbol(["n"])
y = hidet.symbol(["m"])
z = x + y
print(x.shape, y.shape, z.shape) # before: (n,) (m,) (m,)
vadiklyutiy
pushed a commit
that referenced
this pull request
Jul 22, 2024
The previous implementation is incorrect when dealing with a pair of
dimensions that are both symbolic. Minimal example:
import hidet
if __name__ == "__main__":
x = hidet.symbol(["n"])
y = hidet.symbol(["m"])
z = x + y
print(x.shape, y.shape, z.shape) # before: (n,) (m,) (m,)
vadiklyutiy
pushed a commit
that referenced
this pull request
Jul 23, 2024
The previous implementation is incorrect when dealing with a pair of
dimensions that are both symbolic. Minimal example:
import hidet
if __name__ == "__main__":
x = hidet.symbol(["n"])
y = hidet.symbol(["m"])
z = x + y
print(x.shape, y.shape, z.shape) # before: (n,) (m,) (m,)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.