[Fix] Remove lambda in shfl primitives#121
Merged
hjjq merged 1 commit intohidet-org:mainfrom Feb 24, 2023
Merged
Conversation
KTong821
pushed a commit
to KTong821/hidet
that referenced
this pull request
Apr 24, 2024
vadiklyutiy
pushed a commit
that referenced
this pull request
Jul 22, 2024
vadiklyutiy
pushed a commit
that referenced
this pull request
Jul 23, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The shfl primitives use lambda functions. During operator tuning, primitives will be pickled. But since lambda functions cannot be pickled, this will lead to an error when tuning operators that use the shfl primitives. There may be other primitives that have this problem as well, and in the future we may need a more comprehensive solution.