Skip to content

chore: update repository key from a string to an object in package.json#402

Merged
yoshinorin merged 1 commit intomasterfrom
chore/package-json-repository
Mar 31, 2024
Merged

chore: update repository key from a string to an object in package.json#402
yoshinorin merged 1 commit intomasterfrom
chore/package-json-repository

Conversation

@yoshinorin
Copy link
Member

@yoshinorin yoshinorin commented Mar 31, 2024

Why?

As is the title.

See: https://docs.npmjs.com/cli/v10/configuring-npm/package-json#repository

Log

Warning log when I run npm publish --dry-run.

$ npm publish --dry-run
npm WARN publish npm auto-corrected some errors in your package.json when publishing.  Please run "npm pkg fix" to address these errors.
npm WARN publish errors corrected:
npm WARN publish "repository" was changed from a string to an object
npm WARN publish "repository.url" was normalized to "git+https://github.com/hexojs/hexo-deployer-ftpsync.git"
npm notice

Thanks :)

@coveralls
Copy link

coveralls commented Mar 31, 2024

Coverage Status

coverage: 96.873%. remained the same
when pulling 4aafe53 on chore/package-json-repository
into 4e62f87 on master.

@yoshinorin yoshinorin merged commit 96ecd1a into master Mar 31, 2024
@yoshinorin yoshinorin deleted the chore/package-json-repository branch March 31, 2024 13:24
dimaslanjaka pushed a commit to dimaslanjaka/hexo-util that referenced this pull request Oct 3, 2024
@yoshinorin @dimaslanjaka
chore: update repository key from a string to an object in `package…
007c9e6 
….json` (hexojs#402)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@uiolee uiolee uiolee approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@yoshinorin @coveralls @uiolee