fix(url_for): absolute path is processed by relative_url#262
Merged
SukkaW merged 2 commits intohexojs:masterfrom Oct 8, 2021
zkqiang:patch-1
Merged
fix(url_for): absolute path is processed by relative_url#262SukkaW merged 2 commits intohexojs:masterfrom zkqiang:patch-1
SukkaW merged 2 commits intohexojs:masterfrom
zkqiang:patch-1
Conversation
SukkaW
requested changes
Oct 8, 2021
Member
SukkaW
left a comment
There was a problem hiding this comment.
LGTM, but would you mind adding a unit test case for the change?
Merged
Contributor
Author
|
@SukkaW I added it |
SukkaW
approved these changes
Oct 8, 2021
stevenjoezhang
approved these changes
Oct 8, 2021
nevilm-lt
pushed a commit
to nevilm-lt/hexo-util
that referenced
this pull request
Apr 22, 2022
* fix(url_for): absolute path is processed by relative_url * test: absolute urls are processed by relative_url
nevilm-lt
pushed a commit
to nevilm-lt/hexo-util
that referenced
this pull request
Apr 22, 2022
* fix(url_for): absolute path is processed by relative_url * test: absolute urls are processed by relative_url
nevilm-lt
pushed a commit
to nevilm-lt/hexo-util
that referenced
this pull request
Apr 22, 2022
* fix(url_for): absolute path is processed by relative_url * test: absolute urls are processed by relative_url
nevilm-lt
pushed a commit
to nevilm-lt/hexo-util
that referenced
this pull request
Apr 22, 2022
* fix(url_for): absolute path is processed by relative_url * test: absolute urls are processed by relative_url
himanshiLt
pushed a commit
to himanshiLt/hexo-util
that referenced
this pull request
Apr 25, 2022
* fix(url_for): absolute path is processed by relative_url * test: absolute urls are processed by relative_url
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The path will be processed by
relative_urlif you don't judge whether the path is an absolute path firsthexo-util/lib/url_for.js
Lines 19 to 21 in b19468d
eg:
url_for('http://hexo.io/favicon.ico')will be processed as../../http:/hexo.io/favicon.icoSo I think this is a bug