refactor(strip_html): remove striptags deps#232
Merged
SukkaW merged 1 commit intohexojs:masterfrom Sep 20, 2020
Merged
Conversation
yoshinorin
approved these changes
Sep 20, 2020
nevilm-lt
pushed a commit
to nevilm-lt/hexo-util
that referenced
this pull request
Apr 22, 2022
nevilm-lt
pushed a commit
to nevilm-lt/hexo-util
that referenced
this pull request
Apr 22, 2022
nevilm-lt
pushed a commit
to nevilm-lt/hexo-util
that referenced
this pull request
Apr 22, 2022
nevilm-lt
pushed a commit
to nevilm-lt/hexo-util
that referenced
this pull request
Apr 22, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
striptagsis the most safe strip HTML lib (as it implements a AST parser instead of using regex).However:
striptagsimplements a simple Symbol polyfill that Hexo doesn't need (we target latest Node.js LTS)striptagssupports stream and many other features (like tags whitelist) that Hexo doesn't need as wellstriptagsintroduce a bit performance drawback.The PR re-implements the
striptagswithout those unneeded features. The unit test cases are adopted fromstriptags.