perf(external_link): cache config#4134
Merged
SukkaW merged 1 commit intohexojs:masterfrom Mar 30, 2020
Merged
Conversation
curbengh
reviewed
Feb 22, 2020
13d4bd3 to
d0caac7
Compare
yoshinorin
approved these changes
Mar 30, 2020
Member
yoshinorin
left a comment
There was a problem hiding this comment.
LGTM :)
BTW, we can extract this code into another common function :)
Member
Author
|
IMHO, we have no necessary to do that. |
SukkaW
added a commit
to SukkaW/hexo
that referenced
this pull request
Jun 19, 2020
SukkaW
added a commit
to SukkaW/hexo
that referenced
this pull request
Jun 19, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does it do?
This PR add cache for 2 values:
EXTERNAL_LINK_(POST|SITE)_ENABLEDSince hexo will only run filter for
postorsite, it is important to return earlier for another one.EXTERNAL_LINK_(POST|SITE)_CONFIGCurrently, hexo handles
hexo.config.external_linkinside the filter. With config being cached there will be no need to runObject.assign()again and again.How to test
Screenshots
Pull request tasks