Keep blank lines in backtick code block on blockquote (fix #3769)#3770
Conversation
Blank lines in backtick code block on blockquote should be kept. But `backtick_code_block.js` removes them. This patch fixes this behavior. This bug is introduced by the PR hexojs#3765
|
I appreciate the effort, my apology if my comment was misunderstood, I intended it to the Markdown beginners. The reason being this PR is not consistent with GFM, which also doesn't keep blank lines; i.e. Following is demo of GFM behavior: rendered as,
rendered as
I tested the previous PR #3768, it is consistent with GFM. |
|
@curbengh My understanding that blank lines out of a code block are meaningless in GFM. I think a blank line in a code block shuold be kept even if it is in blockquote. For example, the followings contains two blank line
|
The example makes it clearer to me. I just tested this PR, now it's more consistent with GFM. |
|
@curbengh Thank you to review and test! 😄 |
What does it do?
fix #3769
Blank lines in backtick code block on blockquote should be kept.
But
backtick_code_block.jsremoves them.This patch fixes this behavior.
This bug is introduced by the PR #3765
How to test
npm testPull request tasks