Disable to insert extra new line character into the end of backtick code block (fix #3767)#3768
Merged
curbengh merged 1 commit intohexojs:masterfrom Oct 16, 2019
Conversation
…ode block (fix hexojs#3767) A paragraph follows a backtick code block on a blockquote should be included same blcokquote block. But the code block always terminates blockquote. So the blockquote block splits two blocks. This is caused by the implementation of `backtick_code_block.js`. It inserts extra new line character into the end of backtick code block. This patch disables this behavior.
Contributor
|
Using your example: a note for anyone's new to Markdown is that, the "following paragraph" is displayed immediately after the codeblock (no newline), regardless of how many The above wouldn't have new lines either. This is not a limitation of this PR (nor #3765), the behavior is rather expected for Markdown; I figure it could be rather unexpected for those who are new to Markdown. PS: would be displayed as:
not
|
curbengh
approved these changes
Oct 16, 2019
Member
Author
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does it do?
Fix #3767
A paragraph follows a backtick code block on a blockquote should be included same blcokquote block.
But the code block always terminates blockquote.
So the blockquote block splits two blocks.
This is caused by the implementation of
backtick_code_block.js.It inserts extra new line character into the end of backtick code block.
This patch disables this behavior.
How to test
$ npm testPull request tasks