Skip to content

feat: add option to disable meta generator tag#3653

Merged
yoshinorin merged 2 commits intohexojs:masterfrom
curbengh:meta-generator
Aug 6, 2019
Merged

feat: add option to disable meta generator tag#3653
yoshinorin merged 2 commits intohexojs:masterfrom
curbengh:meta-generator

Conversation

@curbengh
Copy link
Contributor

@curbengh curbengh commented Aug 6, 2019 •
edited
Loading

What does it do?

Add meta_generator option (enabled by default) to disable addition of <meta name="generator" content="Hexo 3.9.0">.

Fix #3652 (comment)

How to test

git clone -b meta-generator https://github.com/curbengh/hexo.git
cd hexo
npm install
npm test

Pull request tasks

  • Add test cases for the changes.
  • Passed the CI test.

cc @JoeyBling

@curbengh curbengh changed the title Meta generator feat: add option to disable meta generator tag Aug 6, 2019
@coveralls
Copy link

coveralls commented Aug 6, 2019

Coverage Status

Coverage increased (+0.0008%) to 97.153% when pulling 5d592cc on curbengh:meta-generator into 9b87047 on hexojs:master.

@yoshinorin yoshinorin merged commit 0621184 into hexojs:master Aug 6, 2019
@yoshinorin
Copy link
Member

yoshinorin commented Aug 6, 2019 •
edited
Loading

It works well :)

IMO that it's nice if we disable meta_generator plugin here.

hexo/lib/plugins/filter/index.js

Line 14 in 9b87047

filter.register('after_render:html', require('./meta_generator'));

But, hexo ctx not yet load _config.yml settings when register filter/index.js.

@yoshinorin yoshinorin added the enhancement New feature or request label Aug 6, 2019
@yoshinorin yoshinorin added this to the v4.0.0 milestone Aug 6, 2019
This was referenced Aug 6, 2019
Closed
Closed
yoshinorin referenced this pull request in yoshinorin/hexo-test Aug 6, 2019
@yoshinorin
unregister meta generator filter example
88ed3ca
@curbengh
Copy link
Contributor Author

curbengh commented Aug 6, 2019

But, hexo ctx not yet load _config.yml settings when register filter/index.js.

good catch

@curbengh curbengh deleted the meta-generator branch August 6, 2019 13:06
@curbengh curbengh mentioned this pull request Aug 7, 2019
Merged
@ppoffice ppoffice mentioned this pull request Aug 15, 2019
Closed
@curbengh curbengh mentioned this pull request Oct 11, 2019
Merged
yy4r pushed a commit to yy4r/blogback that referenced this pull request Jan 16, 2020
@curbengh @yy4r
feat: add configs introduced in Hexo v4
378e2b5 
- pretty_urls.trailing_index: hexojs/hexo#3691
- external_link.enable: hexojs/hexo#3675
- meta_generator: hexojs/hexo#3653
- use_date_for_updated: hexojs/hexo#3235
@snyk-bot snyk-bot mentioned this pull request Mar 16, 2020
Merged
liyou54 pushed a commit to liyou54/blog_source that referenced this pull request Jan 19, 2023
@curbengh @liyou54
feat: add configs introduced in Hexo v4
4795d95 
- pretty_urls.trailing_index: hexojs/hexo#3691
- external_link.enable: hexojs/hexo#3675
- meta_generator: hexojs/hexo#3653
- use_date_for_updated: hexojs/hexo#3235
musejournal pushed a commit to musejournal/muse.github.io that referenced this pull request Nov 21, 2024
@curbengh @musejournal
feat: add configs introduced in Hexo v4
e48fb38 
- pretty_urls.trailing_index: hexojs/hexo#3691
- external_link.enable: hexojs/hexo#3675
- meta_generator: hexojs/hexo#3653
- use_date_for_updated: hexojs/hexo#3235
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yoshinorin yoshinorin yoshinorin approved these changes

Assignees

No one assigned

Labels

enhancement New feature or request

Projects

None yet

Milestone

v4.0.0

Development

Successfully merging this pull request may close these issues.

closed tag problem of generated HTML

3 participants

@curbengh @coveralls @yoshinorin