feat(swarm): removed workaround support for mock staging/unstaging#746
Merged
lukasmetzner merged 2 commits intomainfrom Oct 18, 2024
Conversation
…cker swarm With the merge of moby/swarmkit#3116 the mock staging/unstaging is not needed anymore. It was introduced in our csi-driver in this commit: 619fa5c. Which is part of a large PR (squashed commit) that included experimental support for Docker swarm.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #746 +/- ##
==========================================
+ Coverage 34.54% 34.67% +0.13%
==========================================
Files 19 19
Lines 1621 1612 -9
==========================================
- Hits 560 559 -1
+ Misses 1027 1020 -7
+ Partials 34 33 -1 ☔ View full report in Codecov by Sentry. |
Member
|
Is this change backward compatible for previous docker versions? Do we state somewhere that the docker swarm support is experimental? I could only find a statement that we do not provide official support for it. |
Member
|
Changed the scope to feat as we have some user facing changes. |
apricote
requested changes
Oct 16, 2024
Member
apricote
left a comment
There was a problem hiding this comment.
Could you also remove the environment variable from the docker-swarm config.json?
csi-driver/deploy/docker-swarm/pkg/config.json
Lines 30 to 35 in f908f5d
Member
This is only compatible with docker-swarm versions that have the fix from moby/swarmkit#3116. Not sure which versions of docker-swarm include that.
In the docker swarm docs it is mentioned that the support is in beta, though I would say that "beta" is not defined for us. We do not test it and do not publish a version compatibility for docker swarm. |
lukasmetzner
pushed a commit
that referenced
this pull request
Oct 29, 2024
🤖 I have created a release *beep* *boop* --- ## [2.10.0](v2.9.0...v2.10.0) (2024-10-29) ### Features * add support & tests for Kubernetes 1.31 ([#721](#721)) ([85035b9](85035b9)) * allow arbitrary length API tokens ([#724](#724)) ([61c3a0e](61c3a0e)) * allow passing mkfs format options via storage class parameters ([#747](#747)) ([4b9aa4e](4b9aa4e)) * change XFS default options to support older kernels ([#747](#747)) ([4b9aa4e](4b9aa4e)) * drop tests for Kubernetes 1.27 ([#722](#722)) ([d46a54b](d46a54b)) * force pods with volumes to be scheduled on Cloud servers ([#743](#743)) ([702fe01](702fe01)) * fstype is directly passed to mkfs: mkfs.<fstype> ([#749](#749)) ([173bf2f](173bf2f)) * support for SELinux mount ([#756](#756)) ([719247e](719247e)), closes [#582](#582) * Support SINGLE_NODE_MULTI_WRITER capability ([#725](#725)) ([cd53c23](cd53c23)), closes [#327](#327) * **swarm:** removed workaround support for mock staging/unstaging ([#746](#746)) ([465ec21](465ec21)) ### Bug Fixes * do not log sensitive mount options ([#755](#755)) ([0b6e860](0b6e860)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
lukasmetzner
pushed a commit
that referenced
this pull request
Nov 11, 2024
🤖 I have created a release *beep* *boop* --- ## [2.10.0](v2.9.0...v2.10.0) (2024-10-29) ### Features * add support & tests for Kubernetes 1.31 ([#721](#721)) ([85035b9](85035b9)) * allow arbitrary length API tokens ([#724](#724)) ([61c3a0e](61c3a0e)) * allow passing mkfs format options via storage class parameters ([#747](#747)) ([4b9aa4e](4b9aa4e)) * change XFS default options to support older kernels ([#747](#747)) ([4b9aa4e](4b9aa4e)) * drop tests for Kubernetes 1.27 ([#722](#722)) ([d46a54b](d46a54b)) * force pods with volumes to be scheduled on Cloud servers ([#743](#743)) ([702fe01](702fe01)) * fstype is directly passed to mkfs: mkfs.<fstype> ([#749](#749)) ([173bf2f](173bf2f)) * support for SELinux mount ([#756](#756)) ([719247e](719247e)), closes [#582](#582) * Support SINGLE_NODE_MULTI_WRITER capability ([#725](#725)) ([cd53c23](cd53c23)), closes [#327](#327) * **swarm:** removed workaround support for mock staging/unstaging ([#746](#746)) ([465ec21](465ec21)) ### Bug Fixes * do not log sensitive mount options ([#755](#755)) ([0b6e860](0b6e860)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With the merge of moby/swarmkit#3116 the mock staging/unstaging is not needed anymore. It was introduced in our csi-driver in this commit: 619fa5c. Which is part of a large PR (squashed commit) that included experimental support for Docker swarm.
See: