fix: updated capability response of the controller service#732
Merged
lukasmetzner merged 1 commit intomainfrom Oct 4, 2024
Merged
fix: updated capability response of the controller service#732lukasmetzner merged 1 commit intomainfrom
lukasmetzner merged 1 commit intomainfrom
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #732 +/- ##
==========================================
+ Coverage 34.28% 34.52% +0.24%
==========================================
Files 19 19
Lines 1616 1622 +6
==========================================
+ Hits 554 560 +6
Misses 1028 1028
Partials 34 34 ☔ View full report in Codecov by Sentry. |
SINGLE_NODE_MULTI_WRITER needs to be in the response of the ControllerGetCapabilities function to correctly integrate support for SINGLE_NODE_MULTI_WRITER access modes.
7f97b0b to
e224240
Compare
apricote
approved these changes
Oct 4, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #327
SINGLE_NODE_MULTI_WRITER needs to be in the response of the ControllerGetCapabilities function to correctly integrate support for SINGLE_NODE_MULTI_WRITER access modes.
This was missing from #725.
BEGIN_COMMIT_OVERRIDE
chore: updated capability response of the controller service
END_COMMIT_OVERRIDE