Skip to content

fix: remove old checks for storage box delete protection#1201

Merged
apricote merged 1 commit intostorage-boxesfrom
fix-delete-protection
Oct 21, 2025
Merged

fix: remove old checks for storage box delete protection#1201
apricote merged 1 commit intostorage-boxesfrom
fix-delete-protection

Conversation

@apricote
Copy link
Copy Markdown
Member

These checks are no longer necessary as the protection level is now a pointer.

These checks are no longer necessary as the protection level is now a pointer.
@apricote apricote self-assigned this Oct 21, 2025
@apricote apricote requested a review from a team as a code owner October 21, 2025 08:54
@codecov
Copy link
Copy Markdown

codecov bot commented Oct 21, 2025

Codecov Report

❌ Patch coverage is 60.00000% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 69.59%. Comparing base (af147d8) to head (47331ab).
⚠️ Report is 1 commits behind head on storage-boxes.

Files with missing lines Patch % Lines
internal/cmd/storagebox/create.go 0.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@                Coverage Diff                @@
##           storage-boxes    #1201      +/-   ##
=================================================
- Coverage          69.61%   69.59%   -0.02%     
=================================================
  Files                311      311              
  Lines              13989    13983       -6     
=================================================
- Hits                9738     9732       -6     
  Misses              3309     3309              
  Partials             942      942              
Flag Coverage Δ
e2e 49.51% <0.00%> (+0.04%) ⬆️
unit 64.25% <60.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@apricote apricote merged commit 62a0819 into storage-boxes Oct 21, 2025
6 checks passed
@apricote apricote deleted the fix-delete-protection branch October 21, 2025 09:23
apricote added a commit that referenced this pull request Oct 21, 2025
These checks are no longer necessary as the protection level is now a
pointer.
apricote added a commit that referenced this pull request Oct 21, 2025
These checks are no longer necessary as the protection level is now a
pointer.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants