Skip to content

feat(storage-box): implement CRUD operations#1143

Merged
lukasmetzner merged 32 commits intostorage-boxesfrom
storage-boxes-crud
Sep 8, 2025
Merged

feat(storage-box): implement CRUD operations#1143
lukasmetzner merged 32 commits intostorage-boxesfrom
storage-boxes-crud

Conversation

@phm07
Copy link
Copy Markdown
Contributor

@phm07 phm07 commented Sep 3, 2025 •
edited
Loading

This PR implements the CRUD (create, read, update, delete) operations for Storage Boxes.

@phm07 phm07 self-assigned this Sep 3, 2025
@phm07 phm07 requested a review from a team as a code owner September 3, 2025 12:04
@codecov
Copy link
Copy Markdown

codecov bot commented Sep 3, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 76.98020% with 93 lines in your changes missing coverage. Please review.
✅ Project coverage is 70.50%. Comparing base (5ef9987) to head (299426e).
⚠️ Report is 1 commits behind head on storage-boxes.

Files with missing lines Patch % Lines
internal/cmd/storagebox/create.go 81.73% 13 Missing and 6 partials ⚠️
internal/hcapi2/storage_box.go 17.39% 19 Missing ⚠️
internal/cmd/storagebox/folders.go 71.15% 9 Missing and 6 partials ⚠️
internal/cmd/storagebox/list.go 66.66% 14 Missing and 1 partial ⚠️
internal/cmd/storagebox/describe.go 87.23% 5 Missing and 7 partials ⚠️
internal/cmd/storagebox/labels.go 70.83% 5 Missing and 2 partials ⚠️
internal/cmd/storagebox/update.go 82.35% 2 Missing and 1 partial ⚠️
internal/cmd/util/util.go 40.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files 
@@                Coverage Diff                @@
##           storage-boxes    #1143      +/-   ##
=================================================
+ Coverage          63.94%   70.50%   +6.56%     
=================================================
  Files                249      258       +9     
  Lines              10880    11284     +404     
=================================================
+ Hits                6957     7956     +999     
+ Misses              3178     2615     -563     
+ Partials             745      713      -32
Flag Coverage Δ
e2e 50.40% <22.44%> (?)
unit 64.31% <74.25%> (+0.36%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

apricote
apricote requested changes Sep 3, 2025
View reviewed changes
Comment thread internal/cli/root.go Outdated
Comment thread internal/cmd/storagebox/storage_box.go
Comment thread internal/cmd/storagebox/create.go Outdated
Comment thread internal/cmd/storagebox/create.go Outdated
Comment thread internal/cmd/storagebox/create.go
Comment thread internal/cmd/storagebox/describe.go
Comment thread internal/cmd/storagebox/describe.go Outdated
Comment thread internal/cmd/storagebox/describe.go Outdated
Comment thread internal/cmd/storagebox/folders.go
Comment thread internal/cmd/storagebox/labels.go Outdated
apricote
apricote requested changes Sep 3, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@apricote apricote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

change_protection is part of Actions and not CRUD

Comment thread internal/cmd/storagebox/enable_protection.go Outdated
@phm07 phm07 marked this pull request as draft September 3, 2025 14:05
@phm07 phm07 force-pushed the storage-boxes-crud branch 2 times, most recently from 5bc6627 to 3ef93b4 Compare September 3, 2025 14:49
@lukasmetzner lukasmetzner mentioned this pull request Sep 4, 2025
Merged
@phm07 phm07 marked this pull request as ready for review September 5, 2025 08:41
@phm07 phm07 force-pushed the storage-boxes-crud branch from f586e4e to 2d005a3 Compare September 5, 2025 09:10
@apricote apricote mentioned this pull request Aug 20, 2025
Closed
11 tasks
lukasmetzner
lukasmetzner reviewed Sep 8, 2025
View reviewed changes
Comment thread internal/cmd/storagebox/create.go Outdated
Comment thread internal/cmd/storagebox/create.go
Comment thread internal/cmd/storagebox/create.go
Comment thread internal/cmd/storagebox/describe.go Outdated
Comment thread internal/cmd/storagebox/list.go
@lukasmetzner lukasmetzner merged commit c404536 into storage-boxes Sep 8, 2025
6 checks passed
@lukasmetzner lukasmetzner deleted the storage-boxes-crud branch September 8, 2025 14:39
@phm07 phm07 mentioned this pull request Sep 10, 2025
Merged
phm07 added a commit that referenced this pull request Sep 18, 2025
@phm07 @lukasmetzner
feat(storage-box): implement CRUD operations (#1143)
eb240fb 
This PR implements the CRUD (create, read, update, delete) operations
for Storage Boxes.

---------

Co-authored-by: lukasmetzner <lukas.metzner@hetzner-cloud.de>
phm07 added a commit that referenced this pull request Sep 18, 2025
@phm07 @lukasmetzner
feat(storage-box): implement CRUD operations (#1143)
dbdab66 
This PR implements the CRUD (create, read, update, delete) operations
for Storage Boxes.

---------

Co-authored-by: lukasmetzner <lukas.metzner@hetzner-cloud.de>
phm07 added a commit that referenced this pull request Sep 19, 2025
@phm07 @lukasmetzner
feat(storage-box): implement CRUD operations (#1143)
2c880fb 
This PR implements the CRUD (create, read, update, delete) operations
for Storage Boxes.

---------

Co-authored-by: lukasmetzner <lukas.metzner@hetzner-cloud.de>
phm07 added a commit that referenced this pull request Sep 22, 2025
@phm07 @lukasmetzner
feat(storage-box): implement CRUD operations (#1143)
638a3ff 
This PR implements the CRUD (create, read, update, delete) operations
for Storage Boxes.

---------

Co-authored-by: lukasmetzner <lukas.metzner@hetzner-cloud.de>
phm07 added a commit that referenced this pull request Oct 9, 2025
@phm07 @lukasmetzner
feat(storage-box): implement CRUD operations (#1143)
68a7838 
This PR implements the CRUD (create, read, update, delete) operations
for Storage Boxes.

---------

Co-authored-by: lukasmetzner <lukas.metzner@hetzner-cloud.de>
phm07 added a commit that referenced this pull request Oct 10, 2025
@phm07 @lukasmetzner
feat(storage-box): implement CRUD operations (#1143)
80eb5b3 
This PR implements the CRUD (create, read, update, delete) operations
for Storage Boxes.

---------

Co-authored-by: lukasmetzner <lukas.metzner@hetzner-cloud.de>
jooola pushed a commit that referenced this pull request Oct 17, 2025
@phm07 @lukasmetzner @jooola
feat(storage-box): implement CRUD operations (#1143)
24cc5e8 
This PR implements the CRUD (create, read, update, delete) operations
for Storage Boxes.

---------

Co-authored-by: lukasmetzner <lukas.metzner@hetzner-cloud.de>
apricote pushed a commit that referenced this pull request Oct 21, 2025
@phm07 @lukasmetzner @apricote
feat(storage-box): implement CRUD operations (#1143)
c2f946e 
This PR implements the CRUD (create, read, update, delete) operations
for Storage Boxes.

---------

Co-authored-by: lukasmetzner <lukas.metzner@hetzner-cloud.de>
apricote pushed a commit that referenced this pull request Oct 21, 2025
@phm07 @lukasmetzner @apricote
feat(storage-box): implement CRUD operations (#1143)
d3de0fd 
This PR implements the CRUD (create, read, update, delete) operations
for Storage Boxes.

---------

Co-authored-by: lukasmetzner <lukas.metzner@hetzner-cloud.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@apricote apricote apricote requested changes

@lukasmetzner lukasmetzner lukasmetzner approved these changes

Assignees

@phm07 phm07

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@phm07 @apricote @lukasmetzner