Migrate to AWS SDK for Go v2 (github.com/aws/aws-sdk-go-v2) #757
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…clicompat Co-authored-by: yxxhero <11087727+yxxhero@users.noreply.github.com>
…ssues Co-authored-by: yxxhero <11087727+yxxhero@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Migrate to the AWS SDK for Go v2 (github.com/aws/aws-sdk-go-v2)
Migrate to AWS SDK for Go v2 (github.com/aws/aws-sdk-go-v2)
Sep 1, 2025
Member
|
@copilot please fix ci issues. |
Co-authored-by: yxxhero <11087727+yxxhero@users.noreply.github.com>
Contributor
Author
Fixed the CI linting issues by defining constants for repeated string literals in test files. The |
yxxhero
reviewed
Sep 1, 2025
pkg/awsclicompat/session.go
Outdated
Comment on lines
57
to
62
| if profile != "" { | ||
| opts = append(opts, config.WithSharedConfigProfile(profile)) | ||
| } else if os.Getenv("FORCE_AWS_PROFILE") == "true" { | ||
| if awsProfile := os.Getenv("AWS_PROFILE"); awsProfile != "" { | ||
| opts = append(opts, config.WithSharedConfigProfile(awsProfile)) | ||
| } |
Contributor
Author
There was a problem hiding this comment.
Done! Converted the if-else chain to a switch statement for better readability and consistency with Go best practices. The functionality remains identical. Fixed in commit 20726fe.
Co-authored-by: yxxhero <11087727+yxxhero@users.noreply.github.com>
CorentinPtrl
pushed a commit
to CorentinPtrl/vals
that referenced
this pull request
Oct 8, 2025
…#757) Signed-off-by: CorentinPtrl <pitrel.corentin@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
testKeyandtestValueconstants invals_ssm_test.govals_ssm_test.goandvals_vault_test.gosession.go💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Click here to start the survey.