fix: support large output with --enable-live-ouput #1139
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
@flabatut good solution. thanks so much. BTW please ci DCO issue. |
This replaces Scanner with ReadString to handle large amount of data returned by helm ouptut when executing diff action - Changing pkg/helmexec/runner_test.go TestLiveOutput test, adding test with large amount of data, reproducing the issue before applying this fix - Changing pkg/helmexec/runner.go Scanner with Readstring Resolves #893 Signed-off-by: Franck Labatut <franck.labatut@ubisoft.com>
Member
|
@flabatut unit tests failed. |
Signed-off-by: Franck Labatut <franck.labatut@ubisoft.com>
Contributor
Author
|
@yxxhero , using vscode debugger, I missed the data race detector option. |
yxxhero
approved these changes
Nov 11, 2023
virginiabrioso
pushed a commit
to virginiabrioso/helmfile
that referenced
this pull request
Nov 30, 2023
* fix: support large output with --enable-live-ouput This replaces Scanner with ReadString to handle large amount of data returned by helm ouptut when executing diff action - Changing pkg/helmexec/runner_test.go TestLiveOutput test, adding test with large amount of data, reproducing the issue before applying this fix - Changing pkg/helmexec/runner.go Scanner with Readstring Resolves helmfile#893 Signed-off-by: Franck Labatut <franck.labatut@ubisoft.com> * fix: prevent data race Signed-off-by: Franck Labatut <franck.labatut@ubisoft.com> --------- Signed-off-by: Franck Labatut <franck.labatut@ubisoft.com> Signed-off-by: Virginia Tavares <virginia.tavares@ericsson.com>
JadeHayes
pushed a commit
to Secretions/helmfile
that referenced
this pull request
Dec 7, 2023
* fix: support large output with --enable-live-ouput This replaces Scanner with ReadString to handle large amount of data returned by helm ouptut when executing diff action - Changing pkg/helmexec/runner_test.go TestLiveOutput test, adding test with large amount of data, reproducing the issue before applying this fix - Changing pkg/helmexec/runner.go Scanner with Readstring Resolves helmfile#893 Signed-off-by: Franck Labatut <franck.labatut@ubisoft.com> * fix: prevent data race Signed-off-by: Franck Labatut <franck.labatut@ubisoft.com> --------- Signed-off-by: Franck Labatut <franck.labatut@ubisoft.com> Signed-off-by: Jade Hayes <jade.hayes@dominodatalab.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #893
Description
This replaces Scanner with NewReader able to handle large amount of data returned by helm ouptut when executing diff action.
More info (https://stackoverflow.com/a/29444042)
Changes
pkg/helmexec/runner_test.goTestLiveOutput test, adding test with large amount of data, reproducing the issue before applying this fixpkg/helmexec/runner.goScan with ReadstringTest env
Comments
pkg/helmexec/runner.gochanges introduced with this PR, runningTestLiveOutputresults in timeout: