Skip to content

support reading signing passphrase from file or stdin#8394

Merged
technosophos merged 1 commit intohelm:masterfrom
sdorra:master
Sep 18, 2020
Merged

support reading signing passphrase from file or stdin#8394
technosophos merged 1 commit intohelm:masterfrom
sdorra:master

Conversation

@sdorra
Copy link
Contributor

@sdorra sdorra commented Jul 3, 2020 •
edited
Loading

Signed-off-by: Sebastian Sdorra sebastian.sdorra@cloudogu.com

closes #8210

What this PR does / why we need it:

In helm v2 we had the HELM_KEY_PASSPHRASE environment variable to pass the passphrase within a ci process, but in helm v3 we have no way to pass the passphrase without user interaction.

So this pr will add support for reading the signing passphrase from file or stdin e.g.:

echo secret > secret.txt
helm package --sign --key mykey --keyring secring.gpg --passphrase-file secret.txt my-chart
# or
echo secret | helm package --sign --key mykey --keyring secring.gpg --passphrase-file "-" my-chart

If applicable:

  • this PR contains documentation
  • this PR contains unit tests
  • this PR has been tested for backwards compatibility

@helm-bot helm-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jul 3, 2020
@sdorra
support passing signing passphrase from file or stdin
523df76 
Signed-off-by: Sebastian Sdorra <sebastian.sdorra@cloudogu.com>
bacongobbler
bacongobbler approved these changes Jul 7, 2020
View reviewed changes
Copy link
Member

@bacongobbler bacongobbler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code LGTM, though it'll need another maintainer to approve before merging.

@sdorra
Copy link
Contributor Author

sdorra commented Jul 31, 2020

@bacongobbler Is there something i can do to speed things up?

@Lukkie
Copy link

Lukkie commented Aug 6, 2020

I also need this for my helm chart build pipeline. Would be nice if it could be merged sometime soon.

@fcrespofastly
Copy link

fcrespofastly commented Sep 3, 2020

Any chance this gets reviewed by someone else @bacongobbler ? We're willing to use this in our build pipelines too

@bacongobbler
Copy link
Member

bacongobbler commented Sep 15, 2020

Feel free to reach out to the other core maintainers.

@dkulchinsky
Copy link

dkulchinsky commented Sep 16, 2020

Thanks for replying @bacongobbler! but the list of maintainers in OWNERS is quite long, not sure who we should tag here? could you help us figure out who could help us here?

We desperately need this feature for our CI pipeline since we need to sign the charts to generate a provenance file.

@sdorra
Copy link
Contributor Author

sdorra commented Sep 16, 2020

It looks like a large part of the GPG code was written by technosophos.

@sdorra
Copy link
Contributor Author

sdorra commented Sep 16, 2020

Hey @technosophos could you help us with this pr?

@technosophos
Copy link
Member

technosophos commented Sep 17, 2020

I will be reviewing it today or tomorrow.

technosophos
technosophos approved these changes Sep 18, 2020
View reviewed changes
Copy link
Member

@technosophos technosophos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@technosophos technosophos added this to the 3.4.0 milestone Sep 18, 2020
@technosophos
Copy link
Member

technosophos commented Sep 18, 2020

Added this to 3.4.0 since it is a new feature.

@technosophos technosophos merged commit 467bd49 into helm:master Sep 18, 2020
vladfr pushed a commit to vladfr/helm that referenced this pull request Sep 30, 2020
@sdorra @vladfr
support passing signing passphrase from file or stdin (helm#8394)
937dcee 
Signed-off-by: Sebastian Sdorra <sebastian.sdorra@cloudogu.com>
@sdorra sdorra mentioned this pull request Oct 20, 2020
Merged
@enyineer enyineer mentioned this pull request Oct 27, 2020
Closed
zak905 pushed a commit to zak905/helm that referenced this pull request Jan 19, 2023
@sdorra @zak905
support passing signing passphrase from file or stdin (helm#8394)
4959423 
Signed-off-by: Sebastian Sdorra <sebastian.sdorra@cloudogu.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@technosophos technosophos technosophos approved these changes

@bacongobbler bacongobbler bacongobbler approved these changes

Assignees

No one assigned

Labels

size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

3.4.0

Development

Successfully merging this pull request may close these issues.

Use of HELM_KEY_PASSPHRASE to pass passphrase to helm package

7 participants

@sdorra @Lukkie @fcrespofastly @bacongobbler @dkulchinsky @technosophos @helm-bot