feat(install): introduce --create-namespace#7648
feat(install): introduce --create-namespace#7648bacongobbler merged 1 commit intohelm:masterfrom bacongobbler:fix-6794
Conversation
Signed-off-by: Matthew Fisher <matt.fisher@microsoft.com>
|
@ichekrygin can you demonstrate how you tested this? You should just be able to run I manually tested this PR before submission. Happy to hear feedback on this. |
Helm versionGit BranchCreate new chart fooTest deploy foo into existing(default) namespaceShow deployed chart artifactsShow installed helm chartCleanup - delete helm chartUPDATED (see next post) Test install helm chart into non-existing namespace |
Yes, it does work - "user error" (embarrasing: I ran wrong
|
|
I am glad this feature is back in! Just curious, what made you change your mind in light of #5753 (comment) |
|
The user can choose to opt into this functionality or not depending on the presence of the flag. This was not an option before. |
|
To clarify What about:
And:
I am correct, neither of those "justifications" is satisfied with this PR either. Don't get me wrong, I am super happy about this PR change! |
|
If the user assumes they have administrative rights to the cluster, they can opt into the functionality. Otherwise, they’ll be blocked. |
|
The second point is a non-issue. Users who want to modify the namespace can create it with |
|
If the user doesn't have admin functionality the "opt into" functionality is not applicable at all.
Under what circumstances users would choose to be "not-opt-in" or "opt-out"? It is like: "I am an admin and I am installing the chart into the non-existing namespace and I want to be opt-out (or I don't want to be opt-in)", i.e. "I want it to fail" |
|
You may wish to opt out if you know the namespace was created beforehand (like with A simpler example may be in the I think we've exhausted this conversation at this point. We're making a mountain out of a molehill here. The feature has been implemented and is in 3.2. |
👍 |
|
When can we expect this to be released? |
|
v3.2.0 |
|
@bacongobbler If I'm installing the parent chart with helm install, is there a way to pass the --create-namespace flag to a subchart? |
|
We need to have ability to pass custom labels during namespace creation. Please reopen #3503 |
This will be super useful. Any plans on supporting this? A lot of resources filter on namespace selectors which are essentially based on labels on a namespace. |
According to this commit helm/helm#7648 helm 3.2 is able to create namespace when it's not existed.
closes #6794
Signed-off-by: Matthew Fisher matt.fisher@microsoft.com