[v3 backport] chore: Update Golang to v1.24#30771
Merged
mattfarina merged 1 commit intohelm:dev-v3from Apr 18, 2025
Merged
Conversation
Signed-off-by: dongjiang <dongjiang1989@126.com>
Contributor
Author
|
cc @scottrigby |
scottrigby
reviewed
Apr 18, 2025
Member
scottrigby
left a comment
There was a problem hiding this comment.
Question about golangci-lint version. All CI passes still. Otherwise LGTM
| @@ -0,0 +1,2 @@ | |||
| GOLANG_VERSION=1.24 | |||
| GOLANGCI_LINT_VERSION=v1.64 | |||
Member
Collaborator
There was a problem hiding this comment.
@scottrigby main has merged in #30752. This bumped the linter and made numerous changes to pass the linter. This has not been done for v1 of the linter which this branch uses. The v2 version of the linter changed things which is some fixes were needed. Bumping the linter version here will cause CI to fail on dev-v3
mattfarina
approved these changes
Apr 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Backport #30677 to dev v3
Special notes for your reviewer:
If applicable:
docs neededlabel should be applied if so)