Bump golangci lint to last major version and fix static-check errors#30752
Merged
robertsirc merged 11 commits intohelm:mainfrom Apr 16, 2025
Merged
Bump golangci lint to last major version and fix static-check errors#30752robertsirc merged 11 commits intohelm:mainfrom
robertsirc merged 11 commits intohelm:mainfrom
Conversation
Close dependabot helm#30706 Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>
``` WARN The configuration comments are not migrated. WARN Details about the migration: https://golangci-lint.run/product/migration-guide/ WARN The configuration `run.timeout` is ignored. By default, in v2, the timeout is disabled. ``` I've backported comment and timeout Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>
> xinternal/third_party/dep/fs/fs.go:175:3: naked return in func `copyFile` with 59 lines of code (nakedret) Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>
Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>
Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>
Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>
Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>
Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>
460fbdd to
6caa1c1
Compare
Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>
Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>
Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>
6caa1c1 to
a1c2f47
Compare
benoittgt
commented
Apr 14, 2025
| @@ -1,45 +1,63 @@ | |||
| version: "2" | |||
Contributor
Author
There was a problem hiding this comment.
I only ran the golangci migrate command, then reapply the timeout and the big comment. But that's it.
3 tasks
3 tasks
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Trying to close dependabot auto-update #30706
The update triggered few static-check errors that I fixed. It's grouped by commit for easier review
Special notes for your reviewer:
If applicable:
docs neededlabel should be applied if so)Closes: #30706