Inform about time spent waiting resources to be ready in slog format#30696
Merged
robertsirc merged 4 commits intohelm:mainfrom Mar 24, 2025
Merged
Inform about time spent waiting resources to be ready in slog format#30696robertsirc merged 4 commits intohelm:mainfrom
robertsirc merged 4 commits intohelm:mainfrom
Conversation
Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>
3 tasks
98c821c to
8448862
Compare
Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>
Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>
8448862 to
94cb21c
Compare
Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>
821c74b to
4f4c858
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This is the version of #30689 (merged) but for main/helm-v4. As started in #30603, @robertsirc is migrating log to slog. I migrated this function to use slog and added debug reporting. Now, it logs how long we wait for resources to be ready. This helps us better understand how much of the helm upgrade time is due to waiting for resources.
I could change the remaning part in the file but I am not sure what are expected in terms of log level
Special notes for your reviewer:
If applicable:
docs neededlabel should be applied if so)