Report as debug log, the time spent waiting for resources#30689
Merged
mattfarina merged 2 commits intohelm:dev-v3from Mar 21, 2025
Merged
Report as debug log, the time spent waiting for resources#30689mattfarina merged 2 commits intohelm:dev-v3from
mattfarina merged 2 commits intohelm:dev-v3from
Conversation
Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>
godhanipayal
approved these changes
Mar 20, 2025
68632cf to
422c58e
Compare
Contributor
|
@robertsirc want to look at this since he has some log work going on. |
Member
|
So we are moving from log to slog, if we are going to change this I'd rather us convert this over to slog. |
robertsirc
requested changes
Mar 20, 2025
Member
robertsirc
left a comment
There was a problem hiding this comment.
thank you for your pull request this will need some attention before we can approve.
3 tasks
Contributor
Author
mattfarina
approved these changes
Mar 21, 2025
Contributor
Author
|
@robertsirc is it possible to include it in the next patch version |
Member
|
I think it can make the next release which is 3.18.0 is the next minor release and will be on May 14, 2025 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
When trying to improve the speed of a helm upgrade. I think it could be great to see how much time the helm upgrade spent waiting for ressources when you use
--wait. So I thought about adding a small log point with the elapsed time in seconds.Output example
If approved, I can backport it to main/v4.
Similar work: #30685
Special notes for your reviewer:
If applicable:
docs neededlabel should be applied if so)