Skip to content

fix: check group for resource info match (v3 backport)#13644

Merged
mattfarina merged 1 commit intohelm:dev-v3from
mattfarina:backport-13583
Jan 22, 2025
Merged

fix: check group for resource info match (v3 backport)#13644
mattfarina merged 1 commit intohelm:dev-v3from
mattfarina:backport-13583

Conversation

@mattfarina
Copy link
Collaborator

@mattfarina mattfarina commented Jan 17, 2025

What this PR does / why we need it: This is a backport #13583 which is a bugfix.

Special notes for your reviewer:

If applicable:

  • this PR contains user facing changes (the docs needed label should be applied if so)
  • this PR contains unit tests
  • this PR has been tested for backwards compatibility

@jiashengz @mattfarina
fix: check group for resource info match
2ebce78 
Closes: helm#13582

Signed-off-by: Jiasheng Zhu <gnehsaijuhz@hotmail.com>
(cherry picked from commit f5d4881)
@mattfarina mattfarina added this to the 3.17.1 milestone Jan 17, 2025
@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jan 17, 2025
@mattfarina mattfarina mentioned this pull request Jan 17, 2025
Merged
3 tasks
robertsirc
robertsirc approved these changes Jan 17, 2025
View reviewed changes
Copy link
Member

@robertsirc robertsirc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@robertsirc robertsirc added the approved Indicates a PR has been approved by the required number of approvers label Jan 17, 2025
@mattfarina mattfarina added the needs-pick Indicates that a PR needs to be cherry-picked into the next release candidate. label Jan 22, 2025
@mattfarina mattfarina merged commit 9aff8bd into helm:dev-v3 Jan 22, 2025
5 checks passed
@mattfarina mattfarina deleted the backport-13583 branch January 22, 2025 13:58
@mattfarina mattfarina added the picked Indicates that a PR has been cherry-picked into the next release candidate. label Feb 12, 2025
@scottrigby scottrigby added bug Categorizes issue or PR as related to a bug. and removed approved Indicates a PR has been approved by the required number of approvers needs-pick Indicates that a PR needs to be cherry-picked into the next release candidate. labels Nov 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@robertsirc robertsirc robertsirc approved these changes

Assignees

No one assigned

Labels

bug Categorizes issue or PR as related to a bug. picked Indicates that a PR has been cherry-picked into the next release candidate. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

3.17.1

Development

Successfully merging this pull request may close these issues.

4 participants

@mattfarina @robertsirc @scottrigby @jiashengz