Skip to content

fix: check group for resource info match#13583

Merged
mattfarina merged 1 commit intohelm:mainfrom
jiashengz:fix-gvk
Jan 15, 2025
Merged

fix: check group for resource info match#13583
mattfarina merged 1 commit intohelm:mainfrom
jiashengz:fix-gvk

Conversation

@jiashengz
Copy link
Contributor

What this PR does / why we need it:

closes #13582

Special notes for your reviewer:

If applicable:

  • this PR contains user facing changes (the docs needed label should be applied if so)
  • this PR contains unit tests
  • this PR has been tested for backwards compatibility

Closes: helm#13582

Signed-off-by: Jiasheng Zhu <gnehsaijuhz@hotmail.com>
@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Dec 31, 2024
Copy link
Contributor

@sabre1041 sabre1041 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mattfarina mattfarina added the Needs v3 backport Label PRs for v4/main, which are still applicable to v3 so need a separate backport PR label Jan 15, 2025
@mattfarina mattfarina merged commit 1e256b6 into helm:main Jan 15, 2025
4 checks passed
@mattfarina
Copy link
Collaborator

#13644 is the backport to v3

@scottrigby scottrigby added bug Categorizes issue or PR as related to a bug. v3 port complete For completed v2->v3 ports and removed Needs v3 backport Label PRs for v4/main, which are still applicable to v3 so need a separate backport PR labels Nov 5, 2025
@scottrigby scottrigby added this to the 3.17.1 milestone Nov 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Categorizes issue or PR as related to a bug. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. v3 port complete For completed v2->v3 ports

Projects

None yet

Development

Successfully merging this pull request may close these issues.

reinstall fails when resources of the same kind but different group were kept

4 participants