chore: Make retryingRoundTripper type public#13383
Merged
mattfarina merged 1 commit intohelm:mainfrom Oct 9, 2024
Merged
Conversation
1 task
Contributor
Author
Contributor
Author
|
I can also move the RetryingRoundTripper to its own package if that's preferable when making it public. |
hiddeco
reviewed
Oct 8, 2024
| ) | ||
|
|
||
| type retryingRoundTripper struct { | ||
| type RetryingRoundTripper struct { |
Contributor
There was a problem hiding this comment.
The better place for this would probably be pkg/kube, as this contains other Kubernetes client related things.
Contributor
Author
There was a problem hiding this comment.
Sure, I can move it. My initial approach was to make the bare minimum changes....
Contributor
Author
There was a problem hiding this comment.
Updated, thanks for having a look.
Make retryingRoundTripper type public to allow being used in other projects fixes: helm#13052 Signed-off-by: Luis Davim <luis.davim@gmail.com>
robertsirc
approved these changes
Oct 9, 2024
Member
robertsirc
left a comment
There was a problem hiding this comment.
I pulled this down, ran my test against it and this didn't break anything.
mattfarina
approved these changes
Oct 9, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make
retryingRoundTrippertype public to allow it being used in other projectscloses #13052
What this PR does / why we need it:
Some projects use helm as a library but need to create the client outside, making this object public allows using the same functionality without having to maintain a copy.
Special notes for your reviewer:
none.
If applicable:
docs neededlabel should be applied if so)