fix: handle "leader changed" errors#1084
Conversation
cc9ec38 to
1d34d7f
Compare
|
see also helm/helm#13052 |
|
I see there's a new helm tag that includes the changes to make this functionality public, should I update this PR to bump the helm dependency and use that to avoid the extra code copied from there? |
Yes please |
1d34d7f to
a519331
Compare
|
This is strange, the file is here: https://github.com/helm/helm/blob/main/pkg/kube/roundtripper.go and the latest tag is from 2 days ago, well after that file was added but I don't see the round tripper in https://pkg.go.dev/helm.sh/helm/v3@v3.16.3/pkg/kube and even after updating the impoort, go says the type doesn't exist... I even cleaned my mod cache to be sure. |
|
Ok, I see the issue, my change to make the round tripper public was not picked into the |
|
This sounds good to me. If you can please add a reference to the PR with a Thank you for your patience and effort. |
I do have a TODO comment there already but links to the issue, I can also add a link to the PR. |
Fixes fluxcd/flux2/#4804 by copying the solution used in helm/helm#11426 Signed-off-by: Luis Davim <luis.davim@gmail.com>
a519331 to
26bdaec
Compare
|
I've updated the |
Fixes fluxcd/flux2#4804 by copying the solution used in helm/helm#11426