Merged
Conversation
Rename formatChartname to formatChartName for consistency Signed-off-by: myeunee <myeunee@gmail.com>
Signed-off-by: Terry Howe <terrylhowe@gmail.com>
gjenkins8
approved these changes
Sep 29, 2024
3 tasks
mattfarina
approved these changes
Oct 1, 2024
Collaborator
mattfarina
left a comment
There was a problem hiding this comment.
Terry preserved the original commit and added one on top of it to fix the problem. This works.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR renames the variable formatChartname to formatChartName to maintain naming consistency across the codebase. Consistent naming conventions improve code readability and maintainability.
Special notes for your reviewer:
Nothing
Closes: #13310
If applicable:
docs neededlabel should be applied if so)