Rename formatChartname to formatChartName#13310
Conversation
Rename formatChartname to formatChartName for consistency Signed-off-by: myeunee <myeunee@gmail.com>
|
@myeunee this is a beaking change. it requires users to update their chart. |
Sorry. I updated the description. Is there anything else I can do? |
robertsirc
left a comment
There was a problem hiding this comment.
This is a private function. LGTM.
|
Hi, I see that there are three workflows awaiting approval for this PR. If possible, I would appreciate it if the approvals could be reviewed soon. Thank you so much for your time and attention! |
|
Best way to get the conversation started with your PR is to attend the developer meeting Thursday at 9:30 AM PST |
oh. sorry. I miss something. |
| } | ||
|
|
||
| func formatChartname(c *chart.Chart) string { | ||
| func formatChartName(c *chart.Chart) string { |
There was a problem hiding this comment.
You missed occurrences of this name change. Can you please get all of them.
|
Thanks @myeunee for the contrib. #13349 is the fixed version of this PR (Thanks @TerryHowe). Want to close in favor of this? |
|
Note, the PR that was merged instead of this one preserved the commit and author from the work here. It fixed the issue on top of that work. |
Rename formatChartname to formatChartName for consistency
What this PR does / why we need it:
This PR renames the variable
formatChartnametoformatChartNameto maintain naming consistency across the codebase. Consistent naming conventions improve code readability and maintainability.Special notes for your reviewer:
This is a breaking change. Users will need to update their chart to reflect the new variable name format. No additional dependencies or other breaking changes are introduced by this PR.
If applicable:
docs neededlabel should be applied if so)