router: fix prometheus metrics high cardinality issue #789
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes #448 Refers to [CVE(internal)](https://github.com/helm/chartmuseum/security/advisories/GHSA-67g5-8r7h-h9qv) Signed-off-by: scbizu <scbizu@gmail.com>
ce3a8f2 to
f81ffa4
Compare
f81ffa4 to
9e3de5b
Compare
Signed-off-by: scbizu <scbizu@gmail.com>
Signed-off-by: scbizu <scbizu@gmail.com>
|
Sorry to add noise, but any reason this hasn't been merged? The metrics cardinality issue is affecting my production, so I'd be happy to help get this merged. |
Contributor
Author
|
@AnotherKamila Sorry , I've almost forgot this PR , really busy these days 😣 . I will back to this again . |
* deprecate the external dependency of go-gin-prometheus * use zap logger(cm) replace of logrus logger(go-gin-prometheus) for better investigation Signed-off-by: scbizu <scbizu@gmail.com>
Contributor
Author
|
Hi @cbuto , as we talked before (if I remember it's right) , I've moved the prometheus middleware inside CM , and remove the outside dependency as it is not maintained recently. Please take a look again ? (And I add the toolchain in go.mod 😆) |
cbuto
approved these changes
Mar 4, 2025
Contributor
Author
|
@AnotherKamila Try to bump to the canary image to get the bug fixed 👋 |
dmytrop-salt
pushed a commit
to Secful/chartmuseum
that referenced
this pull request
Oct 13, 2025
* router: fix prometheus metrics high cardinality issue Closes helm#448 Refers to [CVE(internal)](https://github.com/helm/chartmuseum/security/advisories/GHSA-67g5-8r7h-h9qv) Signed-off-by: scbizu <scbizu@gmail.com> * mod: bump Signed-off-by: scbizu <scbizu@gmail.com> * ci: build PR workflow bumps to Go 1.23 Signed-off-by: scbizu <scbizu@gmail.com> * server: fixup tests Signed-off-by: scbizu <scbizu@gmail.com> * router: move prometheus middleware inside CM * deprecate the external dependency of go-gin-prometheus * use zap logger(cm) replace of logrus logger(go-gin-prometheus) for better investigation Signed-off-by: scbizu <scbizu@gmail.com> --------- Signed-off-by: scbizu <scbizu@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes Possibly high cardinality on chartmuseum_requests_total labels #448
Refers to CVE(internal)