refactor: use sync map instead for map string #549
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
@nerdeveloper - can you add the |
Member
Author
|
Yes |
Member
Author
Done |
cbuto
reviewed
Feb 9, 2022
Contributor
|
@nerdeveloper And please fix your DCO verification ? |
scbizu
requested changes
Feb 10, 2022
| TimestampTolerance time.Duration | ||
| ExternalCacheStore cache.Store | ||
| InternalCacheStore map[string]*cacheEntry | ||
| InternalCacheStore sync.Map |
Contributor
There was a problem hiding this comment.
Can we wrap the sync.Map inside a specialized structure , for example type memoryCacheStore struct { sync.Map } maybe , and wrap the Load and Store func ? Doing a type assertion every where seems ugly though .
helm#540) Bumps [github.com/chartmuseum/storage](https://github.com/chartmuseum/storage) from 0.12.2 to 0.12.3. - [Release notes](https://github.com/chartmuseum/storage/releases) - [Commits](chartmuseum/storage@v0.12.2...v0.12.3) --- updated-dependencies: - dependency-name: github.com/chartmuseum/storage dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: nerdeveloper <odirionye@gmail.com>
Bumps [github.com/prometheus/client_golang](https://github.com/prometheus/client_golang) from 1.12.0 to 1.12.1. - [Release notes](https://github.com/prometheus/client_golang/releases) - [Changelog](https://github.com/prometheus/client_golang/blob/main/CHANGELOG.md) - [Commits](prometheus/client_golang@v1.12.0...v1.12.1) --- updated-dependencies: - dependency-name: github.com/prometheus/client_golang dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: nerdeveloper <odirionye@gmail.com>
* fix: avoid panic with dynamic depth configured Signed-off-by: Casey Buto <cbuto@d2iq.com> * test: Add test for dynamic depth route Signed-off-by: Casey Buto <cbuto@d2iq.com> Signed-off-by: nerdeveloper <odirionye@gmail.com>
…d up builds (helm#544) Signed-off-by: Casey Buto <cbuto@d2iq.com> Signed-off-by: nerdeveloper <odirionye@gmail.com>
Signed-off-by: nerdeveloper <odirionye@gmail.com>
Signed-off-by: nerdeveloper <odirionye@gmail.com>
Co-authored-by: Casey Buto <cbuto22@gmail.com> Signed-off-by: nerdeveloper <odirionye@gmail.com>
48a7463 to
dc067d9
Compare
Contributor
|
@nerdeveloper is there anything we can help with here? |
Member
Author
|
Yes, @cbuto, I tried to refactor to sync map, but the race condition still exists. i am having a hard time debugging this |
Member
Author
|
I am going to close this PR, as @cbuto has picked it and finished it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: nerdeveloper odirionye@gmail.com